Commit Graph

8284 Commits

Author SHA1 Message Date
Tony Murray
36080f5ca3
Ports min polled period of 1 (#15472)
Prevent divide by 0
2023-10-18 09:06:07 -05:00
Tony Murray
0e453e5938
API: allow add device to set location (#15469) 2023-10-18 02:00:39 -05:00
Tony Murray
78a85fe3ef
Ports module: fix nulls not updating (#15467)
* Ports module fix nulls not updating

* Fix broken test data
I'd like to see how it came out broken in the first place, but I don't have access

* Update json data

* Fix fortivoice snmprec

* Fix scs-ks

* Fix bad siteboss550 data
2023-10-18 01:59:18 -05:00
Jellyfrog
187a4d36de
Allow inserting null values for sensors (#15470)
* Allow inserting null values for sensors

* Update ericsson-ml.inc.php

* Update rittal-cmc-iii-sensors.inc.php
2023-10-17 13:18:17 +02:00
Tony Murray
7a8e479b61
Unix Agent and Application fixes (#15460)
* Unix Agent and Application fixes

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-16 03:40:40 -05:00
Tony Murray
a51e70d067
Graphing: error when device is not found (#15459) 2023-10-15 06:02:21 -05:00
bnerickson
78a4bfb9d9
Adding Socket Statistic Application Support (#15307) 2023-10-13 22:45:03 -05:00
cwispy
c30c24e22c
Fortimail add mail queues message count (#15444)
* Update fortimail.yaml

Added mail queues message count

* Update fortimail.snmprec

Update test data for FortiMail queues

* Add sensors fortimail.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-10-13 22:24:47 -05:00
Tony Murray
a5198d7d57
Remove some lightly used or unused dbFacile functions (#15418)
* Remove some lightly used or unused dbFacile functions
['NULL'] legacy behavior seems unsupported, replace with actual nulls

* Fix refactor mishap

* another

* update baseline

* these were very wrong... what happened?
2023-10-12 09:15:03 -05:00
Tony Murray
0540c56d0f
Add application metrics model and relationships (#15417)
* Add application metrics model and relationships

* update schema check file

* Add missed index

* Update testing definition

* sqlite can't create the id later

* update schema dumps

* update testing_persistent schema

* update baseline
2023-10-12 02:24:27 -05:00
Tony Murray
7c5b0e3612
Fix port module wrong null (#15431)
* Fix port module wrong null

* Update test data

* revert incidental data changes
2023-10-11 20:42:05 -05:00
Tony Murray
e6be5f777b
Use modern device attrib handling (#15429)
* Use modern attrib handling
Remove device attribs array.

fixes #15422

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-11 18:29:47 -05:00
Tony Murray
a8b69c1393
Fix discovery protocols again (#15434)
* Fix discovery protocols again
earlier fix had a typo

fixes #15432

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-11 10:20:12 -05:00
Tony Murray
aa455862e9
Fix bug saving snmpv3 device changes (#15419) 2023-10-08 18:56:48 -05:00
Tony Murray
14d9d66529
Agent: Packages fixes (+pacman) (#15415)
* Agent: Packages fixes
Don't try to save invalid packages, probably due to script failure on device.
Add pacman support

* Apply fixes from StyleCI

* Add version

* cast to number

* Update includes/polling/unix-agent/packages.inc.php

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
2023-10-08 18:37:33 -05:00
Tony Murray
c87c6e8b8e
Remove legacy addhost code (#15376)
* Remove legacy addhost code
Update webui addhost
Update device snmp settings page
Update discovery protocols device discovery (no longer force full new device discovery in process)

* remove baseline exceptions

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-07 22:02:45 -05:00
Tony Murray
685d11d4f1
Misc fixes 42 (#15413)
* Misc Fixes

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-07 21:39:16 -05:00
Tony Murray
ac23c133d9
Fix an agent bug if a process ran more than 999 days (#15411)
* Fix an agent bug if a process ran more than 999 days
Increase it to 274 years before that happens ;)
Fix a few other small bugs

* Update schema check file
2023-10-07 20:14:00 -05:00
Tony Murray
e53436b6a3
Calculate downtime from device_outages table (#15397)
* Calculate downtime from device_outages table

* refactor
2023-10-06 20:37:23 -05:00
Tony Murray
6d9178cd42
Fix graph errors (#15407)
Some graphs were generating an error that wasn't being correctly output as an image
2023-10-06 08:22:22 -05:00
Tony Murray
d8c372bbf4
Refactor MAC utilities into a single class (#15379)
* Refactor MAC utils to a new utility class

* Apply fixes from StyleCI

* Inline functions
Add tests
Handle bridgeid format

* Apply fixes from StyleCI

* Dedicated code path for stp bridge parsing, and improve STP output a bit

* Correctly parse dot1dBaseBridgeAddress and don't store int in bool field

* trim any unexpected character from bridge addresses, add extra test data.

* better comment

* barsBridge can handle dot1dBaseBridgeAddress correctly now

* parseBridge, check for properly formatted mac first.

* update test data, empty data = empty mac

* Fix new usage after rebase

* import

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-06 07:34:14 -05:00
Tony Murray
908aef6596
Fix MAC search sql injection (#15402)
unparameterized variable
2023-10-05 23:04:04 -05:00
Tony Murray
7fe2614114
Fix xss in device groups overview (#15399) 2023-10-05 23:03:26 -05:00
Tony Murray
37eb0f1fa6
Hide unchangeable core module (#15395)
Core is an internal module do not show a toggle for it as it cannot be disabled.
2023-10-05 21:00:14 -05:00
Tony Murray
087d588102
Vmware vminfo modernize (#15008)
* Vmware vminfo
Remove legacy file and migrate to OS discovery

* tighter

* ios_stp-vlans working correctly now

* Make vmwVmGuestOS nullable

* Discover os info too

* VM Info module

* Apply fixes from StyleCI

* Fix log severity

* Fix log severity (more)

* VM Info module

* Poll with ESXi too because it is lightweight
add test data

* poller data now too

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-05 19:49:26 -05:00
Tony Murray
9fca01830c
Update Tnmsne table backend (#15384)
remove ridiculous sql injection vulnerability
2023-10-05 10:32:21 +02:00
Tony Murray
be24993cbb
Remove snmp functions that are barely used (#15377)
* Remove snmp functions that are barely used
Replace them with SnmpQuery calls

* Apply fixes from StyleCI

* Fix missing namespace

* Import Oid

* No more variables left may be repeated multiple times at the end with snmpsim, remove them all

* update data fixed by SnmpResponse bugfix

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-05 01:29:22 -05:00
Tony Murray
e0444bffcf
Deprecate poller.php (#15370)
* Deprecate poller.php

* Apply fixes from StyleCI

* Remove references to poller.php
Leave wrapper...

* fix python style

* update wraper to call lnms device:poll

* Quiet output too

* make pb happy

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-04 16:32:02 -05:00
rolfbergheim
008efe41cd
eNexus: added some groups and corrected some references (#15129)
* Added grouping on the Voltage displays

Added groupings to better show which voltage and current variables that belongs together.

* Update enexus.json

* Update enexus_eltek-smartpack2-syst.json

* Update enexus_enexus.json

* Update enexus_smartpacks.json

* Update enexus_smartpacks2.json

* Update enexus_sp2touch.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-10-04 16:26:32 -05:00
Daniele Santi
96e5c5ee78
Fix Raisecom devices having not increasing OIDs on snmpwalk (#15365)
* Add useful IF-MIB entries as 'unordered oids'
to Raisecom ROS and ROAP definitions because
they don't have increasing OIDs in snmpwalk

* Bump composer/composer from 2.5.8 to 2.6.4 (#15364)

Bumps [composer/composer](https://github.com/composer/composer) from 2.5.8 to 2.6.4.
- [Release notes](https://github.com/composer/composer/releases)
- [Changelog](https://github.com/composer/composer/blob/main/CHANGELOG.md)
- [Commits](https://github.com/composer/composer/compare/2.5.8...2.6.4)

---
updated-dependencies:
- dependency-name: composer/composer
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update aviat-wtm.json (#15368)

* sort services by type and name (#15367)

* Added support for Cambium cnMatrix switches (#15351)

* Added support for Cambium cnMatrix switches

* Fixed styling issues

* Fixed styling issues

* Fixed duplicate, incorrectly labeled LLDP-EXT-DOT3-MIB and LLDP-EXT-DOT1-MIB

* Corrected MIB with the same name but with different OIDs configured: LLDP-EXT-MED/-CAMBIUM/-MIB

* Removed my added duplicate MIBs

* Removed unused MIBs

* Rearrange AD auth settings (#15363)

so it makes more sense, add missing settings

* Specify radius attributes for auth roles (#15374)

* Specify radius attributes for auth roles

* Clarify that any role can be defined

* Fixes check_dns against localhost when a search-domain is configured (#15373)

* Added extra ASN-range comments, added Priv eBGP on host details, changed color to light-blue instead of red (#15372)

* Moxa EDS improve discovery (#15375)

Consolidate walks so less need to be performed.
This should help a lot since each device model has its own MIB.

* Remove unused functions (#15371)

* Remove unused functions
inline other legacy functions

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>

* Availability module fixes (#15369)

* Refactor poller to allow modules to run even if the device is down
Include core in config (but not webui) to avoid silly shenanigans
Inject datastore into polling

* Needed to split datastore interface

* Cleanup some data_udpate() references

* Apply fixes from StyleCI

* Fix legacy poller :D

* Output to the correct stream

* Fix lint issues

* Apply fixes from StyleCI

* Fix discovery not including core and submodule handling

* Use whereRaw

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Justin Lentz <monkeybrains7@gmail.com>
Co-authored-by: SourceDoctor <sourcehhdoctor@googlemail.com>
Co-authored-by: Noah Roufus <noaheroufus@gmail.com>
Co-authored-by: Tony Murray <murraytony@gmail.com>
Co-authored-by: barryodonovan <barry.odonovan@lightnet.ie>
Co-authored-by: Tim de Boer <tim@tim427.net>
Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-04 15:24:33 -05:00
Tony Murray
c1258320f8
Availability module fixes (#15369)
* Refactor poller to allow modules to run even if the device is down
Include core in config (but not webui) to avoid silly shenanigans
Inject datastore into polling

* Needed to split datastore interface

* Cleanup some data_udpate() references

* Apply fixes from StyleCI

* Fix legacy poller :D

* Output to the correct stream

* Fix lint issues

* Apply fixes from StyleCI

* Fix discovery not including core and submodule handling

* Use whereRaw

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-04 10:32:59 -05:00
Tony Murray
4211b1c46f
Remove unused functions (#15371)
* Remove unused functions
inline other legacy functions

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-04 10:17:34 -05:00
Tony Murray
3366ecad39
Moxa EDS improve discovery (#15375)
Consolidate walks so less need to be performed.
This should help a lot since each device model has its own MIB.
2023-10-04 10:17:18 -05:00
Tim de Boer
15fd452b8a
Added extra ASN-range comments, added Priv eBGP on host details, changed color to light-blue instead of red (#15372) 2023-10-04 10:07:14 -05:00
Tim de Boer
27be56ecf1
Fixes check_dns against localhost when a search-domain is configured (#15373) 2023-10-04 09:15:54 -05:00
Noah Roufus
d472c5cbff
Added support for Cambium cnMatrix switches (#15351)
* Added support for Cambium cnMatrix switches

* Fixed styling issues

* Fixed styling issues

* Fixed duplicate, incorrectly labeled LLDP-EXT-DOT3-MIB and LLDP-EXT-DOT1-MIB

* Corrected MIB with the same name but with different OIDs configured: LLDP-EXT-MED/-CAMBIUM/-MIB

* Removed my added duplicate MIBs

* Removed unused MIBs
2023-10-04 01:50:41 -05:00
SourceDoctor
65daa10b1b
sort services by type and name (#15367) 2023-10-04 01:40:53 -05:00
Noah Roufus
ca5b75a200
Added support for Cambium cnWave60 gear (#15358) 2023-09-27 18:07:08 -05:00
Tim de Boer
36cc6c3237
Fixing Private eBGP visualization, corrected 16bit ASN private range, added 32bit ASN range (#15357)
* Updated Install-LibreNMS.md

Default PHP version of Debian 11 (following this documentation) is 8.2 currently, instead of 8.1

* Fixed Markdown/Parse mode for Telegram

* Fixing Private eBGP visualization, corrected 16bit ASN private range, added 32bit ASN range

* Removed quotes
2023-09-27 13:48:27 -05:00
Tim de Boer
c1008c44b8
Fix BGP peer IP missing in Routing page (#15352)
* Updated Install-LibreNMS.md

Default PHP version of Debian 11 (following this documentation) is 8.2 currently, instead of 8.1

* Fixed Markdown/Parse mode for Telegram

* Changed peer_iden to peer_addr in routing/bgp.inc.php
2023-09-27 07:14:13 -05:00
Tim
2ee837eb90
Fix incorrect pages offset on app ntp page (#15349)
* Update app_ntp.inc.php

Fixes ISSUE 15344
- Corrects start point in table when showing NTP APP
- Corrects blank page when showing ALL NTP entries

* Update app_ntp.inc.php

Use row count for page start not a hard coded 10
2023-09-26 20:47:45 -05:00
Cyril LAVIER
f9ef5fe3fe
Add model for Christie Digital projectors (#15088) 2023-09-25 18:39:20 -05:00
PipoCanaja
584768549a
Improve "count" graphs for F5OS (#15335)
* fix rrd_type: COUNTER and change index to force new graphs

* tests

* remove number in index
2023-09-25 18:28:40 -05:00
Noah Roufus
57e1d3ff48
Calix AXOS Sensor Changes (#15343)
* Sync'd up MIB changes

* Added new ONT sensors: admin/oper state, rx/tx levels
2023-09-25 15:30:30 -05:00
PipoCanaja
91fed0b118
Refactor discovery-protocols (#15324)
Refactor discovery-protocols

Update zynos.yaml
Update discovery-protocols.inc.php
Allow unordered for LLDP-MIB discovery in Zyxel switches
2023-09-24 15:20:10 -05:00
PipoCanaja
6ba103db68
Device NAC page to Laravel Blade (#15329) 2023-09-24 15:19:25 -05:00
SourceDoctor
5c9f3c80e5
show device group on device overview (#15338)
* show device group on device overview

* .

* better styling on device group display
2023-09-24 11:32:01 -05:00
SourceDoctor
6e592f99c1
Scale disk spezific SMART Graph from 0 (#15339) 2023-09-24 18:12:11 +02:00
SourceDoctor
c0a233700c
show never polled information (#15341) 2023-09-24 18:10:11 +02:00
SourceDoctor
88eee297c4
show Temperature Graphs on Smart App Overview (#15342) 2023-09-24 18:09:25 +02:00
James
3e3d15c297
Adding Active Power in Watts to APCs (#15337)
* Adding oid upsAdvOutputActivePower

Adding oid upsAdvOutputActivePower under the power section as this value is in watts.

* Create apc_smx750.json

Adding test JSON data for APC changes

* Create apc_smx750.snmprec

Adding snmpsim test data for APC changes

* Update apc_smx750.json

* Update apc_smx750.snmprec

* Update apc_smx750.json
2023-09-23 16:35:40 -05:00
Wheel
52bc8dc7de
Device stulz WIB8000 (#15271)
* Device stulz WIB8000

* Fix multiplier oid is in bar + 1 decimal

* Fixed multiplier

* More stulz sensors
2023-09-20 06:41:31 -05:00
Tony Murray
274a89bcb4
Fix eventlog debug code left in (#15331) 2023-09-18 09:14:52 -05:00
Tony Murray
8fd8d9b06a
Fix unescaped output in ipv6 search page (#15327) 2023-09-15 16:05:08 -05:00
MrMoCoDev
7bbe0a22fd
FIX TP-Link JetStream 3.0.0 Build 20180511 Rel.36491(s) T1500-28PCT 3.0 (#15318) 2023-09-14 10:33:23 -05:00
Tony Murray
52e264a417
Allow port search API to search ifAlias again (#15320)
Was accidentally omitted when fixing a security issue with the API.
fixes #15316
2023-09-14 08:45:20 -05:00
Tony Murray
2c5960631c
Fix injection vulnerability in fdb search page (#15315)
unescaped search output
reported by: https://huntr.dev/users/hainguyen0207
2023-09-14 00:22:42 -05:00
Tony Murray
cfd642be6a
Fix injection vulnerability in ports pages (#15314)
* Fix injection vulnerability in ports pages
Unescaped output
reported by: https://huntr.dev/users/hainguyen0207

* fix style
2023-09-14 00:19:12 -05:00
Tony Murray
03c4da62c8
Fix another addcslashes incorrect escape in eventlog (#15313)
and many more
reported by: https://huntr.dev/users/hainguyen0207
2023-09-14 00:07:08 -05:00
Tony Murray
e4c46a4536
Fix another injection in ipv4 search page (#15312)
Reported by: https://huntr.dev/users/trunggg02
2023-09-13 23:48:24 -05:00
Tony Murray
1194934d31
Fix injection in search pages ipv4, etc (#15311)
Reported by: https://huntr.dev/users/hainguyen0207
2023-09-13 23:35:49 -05:00
Tony Murray
49d66fa31b
Fix improperly escaped output in outages page (#15310)
Fixes XSS reported by https://huntr.dev/users/hainguyen0207
2023-09-13 23:10:37 -05:00
Justin Lentz
a1eb90fe69
Fix smartos-dcp-m.yaml (#15295)
* Update smartos-dcp-m.yaml

* Update smartos-dcp-m_dcp-m40-pam4-zr.json

* Update smartos-dcp-m_dcp-m40-pam4-zr.json

* Update smartos-dcp-m_dcp-m40-pam4-zr.json

* Update smartos-dcp-m_dcp-m40-pam4-zr.json

* Update smartos-dcp-m_dcp-m40-pam4-zr.json

* Update smartos-dcp-m_dcp-m40-pam4-zr.json

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m_dcp-m40-pam4-zr.json

* Remove bogus 0 values

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update DCP-INTERFACE-MIB

* Update SO-TC-MIB

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m.yaml

* Test data update

* Update smartos-dcp-m.yaml

* Update smartos-dcp-m_dcp-m40-pam4-zr.json

* Remove Grouping

* Update Test
2023-09-12 10:05:08 +02:00
Tony Murray
0f7a066f3a
Fix issue with rrdcached with bad input (#15301)
fixes #15299
2023-09-11 01:18:28 +02:00
Tony Murray
0f8fb0aea3
RouterOS: use mtxrGaugeTable instead of mtxrHealthGroup (#15289)
* RouterOS: use mtxrGaugeTable instead of mtxrHealthGroup
Should now exactly match System > Health
Historical data will be lost

* fix yaml

* Fix numeric oid

* Update test data, add table to crs317

* Add groups and cleanup yaml

* revert state_name as it is used in the rrd file name

* Except the gauge table state sensor

* Group Health -> System

* update json

* update json
2023-09-08 13:55:51 -05:00
Slashdoom
e141ee8b8c
Update customoid.inc.php (#15260)
include descr and unit in tags
2023-09-08 07:44:19 -05:00
Zane C. Bowers-Hadley
2618a99be5
Application Soft Delete (#15270)
* add the softdeletes migrations for applications

* add working migration file

* add deleted_at to db schema.yaml for applications

* update includes/html/forms/application-update.inc.php to work with softdeletes

* update includes/html/pages/device/edit/apps.inc.php for softdelete

* update includes/discovery/applications.inc.php to work with softdelete

* minor updates to application-update.inc.php for disabling

* style cleanup

* set discovered when running discovery

* update application tests to include deleted_at

* add deleted_at to a missed test

* a few more tweaks for opensips

* add a missing deleted_at for linux_suricata_extract-v1

* fix fillable for Application model

* massive cleanup of the application update widget thingy

* improve the code for discovery and using Laravel

* add a missing line to app/Models/Application

* add a missing include to app/Models/Application.php

* record includes for Application model

* remove apps from the applications table when a device is deleted

* revert to using upcert and where for discovery to fix CI

* make discovered fillable and set it when running discovery... convert back to firstOrNew

* clean up application discovery a bit and use observer

* style fix

* spelling fix... disablaed -> disabled

* rever removal to just use where

* cleanup app removal on delete

* add restored to ModuleModelObserver

* delete -> forcedelete fix

* apply the suggested changes

* use murrants other suggestion

* style fix
2023-09-06 16:34:39 -05:00
Tony Murray
6d1b1ac1fa
Fix port ifAlias polling (#15279)
Fixes static ifAlias as well.
2023-09-03 22:47:23 -05:00
Wheel
a6ccb596df
Custom ssh,telnet port with oxidized (#15255)
* Custom ssh,telnet,http port with oxidized

* Lint fixes

* copy paste minors
2023-09-03 20:15:51 -05:00
eskyuu
298d217a8b
Added support for Nutanix VM count, disk state, CPU usage and RAM usage (#15252)
* Added support for Nutanix VM count, disk state, CPU usage and RAM usage

* Added num_oid values required for pull request

* Fixes for Nutanix AOS graphs
2023-08-30 21:11:04 +02:00
Tony Murray
2cd207028a
Implement RBAC (only built in roles) (#15212)
* Install bouncer

* Seeder and level migration

* Display and edit roles

* remove unused deluser page

* Update Radius and SSO to assign roles

* update AlertUtil direct level check to use roles instead

* rewrite ircbot auth handling

* Remove legacy auth getUserlist and getUserlevel methods, add getRoles
Set roles in LegacyUserProvider

* Small cleanups

* centralize role sync code
show roles on user preferences page

* VueSelect component WIP and a little docs

* WIP

* SelectControllers id and text fields.

* LibrenmsSelect component extracted from SettingSelectDynamic

* Handle multiple selections

* allow type coercion

* full width settings

* final style adjustments

* Final compiled assets update

* Style fixes

* Fix SSO tests

* Lint cleanups

* small style fix

* don't use json yet

* Update baseline for usptream package issues

* Change schema, not 100% sure it is correct
not sure why xor doesn't work
2023-08-28 00:13:40 -05:00
Félix Bouynot
93d7286381
Initial support for f5os (#15241)
* Create F5-COMMON-SMI-MIB

* Create F5-PLATFORM-STATS-MIB

* Create f5os.yaml

* Create f5os.yaml

* Create f5os_f5os.snmprec

* Create f5os_f5os.json

* Remove remaining test line

* Add mandatory num_oid

* Add num_oid for fanspeed

* Force use of index for fanspeed

* Force index for temperature + add snmp_flags to make it work

* Update test data

* Update test data
2023-08-25 01:53:21 +02:00
fbourqui
c3d0426311
WebUI Services, generate more compact table (#15243)
Fix edit, delete button on top of each other,
2023-08-25 01:51:01 +02:00
Tony Murray
d7ae34d390
Fix API availability graph duration (#15250)
Add default duration
2023-08-24 14:40:33 -05:00
Tony Murray
3b7185d825
Fix manual port speed storage (#15238)
* Fix port speed setting
Due to a bug all manually configured port speeds were lost and will need to be reconfigured.
This allows them to work in a way that will prevent that issue in the future by storing the speed with the override.
Includes notification.

* Fix date

* Add URL

* Spelling fix
2023-08-21 10:48:13 -05:00
Tony Murray
b04e31710d
Fix ifSpeed override not being applied (#15237) 2023-08-21 00:31:19 -05:00
Tony Murray
47dfb34cf0
Print a useful error if logfile is not writable (#15233) 2023-08-19 09:09:00 -05:00
Knut Petter Ølberg
a3fbed30bb
Fix version comparison for RouterOS (#15227)
Switched to the suggested version_compare function
2023-08-18 15:51:16 -05:00
Arjen Zonneveld
7e910d60af
Fix Memmory spelling (#15231) 2023-08-18 15:49:33 -05:00
zappiehost
8ee1a20346
Add BIRD2 BGP Peers application support (#14466)
* Add BIRD2 application support and docs

* Remove whitespacing

* Update includes/polling/applications/bird2.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>

* Correct the variable names to reflect their actual content and also use the remote address to display on the webUI as opposed to the unrelated peerid aka router-id

* Style fixes

* Style fixes

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-08-14 08:16:45 -05:00
Tony Murray
6e4d124619
Misc fixes 2 (#15190)
* Fix error when missing poller data

* Apparently impossible to detect regex without error, so require regex always.  Update docs.

* Apparently this adva code is garbage :D

* Missing count sensor type

* Processor handle missing input

* Handle missing ifName a little better

* Yep, ports module is a dumpster fire.  Attempt to clean up some.

* apparently os yaml trying to replace on non-existent fields

* Might as well define all sensor type units

* revert previous fix, real issue was vlans module does not have polling.
2023-08-13 18:43:52 +02:00
Tony Murray
d865e3b372
Always mark device last_discovered (#15218)
Previously, if the device was ping only, it wasn't marked as discovered.
Now we always run discovery, but basically all it does is update last_discovered.
2023-08-13 16:56:54 +02:00
Wheel
8bd8682bae
APC new sensors and fix (#15179)
* APC last input failure & display outlet name

* SNMP data & test files

* fix total energy divisor

* fix ap8853

* fix ap8959eu3

* test fixes

* Adjust sensor descr new format #{outletid} : {outletlabel}
2023-08-10 20:10:31 -05:00
Tony Murray
e100d17665
Netscaler, don't use 0 divisor (#15204) 2023-08-05 12:12:53 -05:00
Tony Murray
d1b7004fef
Severity Enum (#14620)
* Severity Enum
Replace old Alert constants

* Fix whitespace

* Additional uses

* style fixes

* Fix test too

* More missed locations

* More
2023-08-05 12:12:36 -05:00
eskyuu
6fb784a321
Apply service templates on a per-device basis (#15024)
* Created and use a function to apply service templates on a per-device basis

* formatting fix
2023-08-04 19:05:07 -05:00
jgelinas
65b4db8172
Openmanage enterprise modular (#14408)
* Add support for OpenManage Modular devices.

* Update dell-ome-m.yaml

Remove commented out dmmGlobalSystemStatus num_oid 
Change Max/Min Power to Peak/Min Usage

* json test file for open manage modular support

* Update dell-ome-m_dell-ome-m.json

* Update dell-ome-m_dell-ome-m.snmprec

* Update dell-ome-m_dell-ome-m.json

* Update dell-ome-m_dell-ome-m.snmprec

* Update dell-ome-m_dell-ome-m.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-08-03 19:55:09 -05:00
VTS
7381c2046c
API get_location (#14779)
* api endpoint to get specific location

* missing nl

* fix missed styleci error

* make requested change
2023-08-03 19:35:20 -05:00
Tony Murray
12f8bb2040
MAC Vendor OUI use scheduler (#15187)
* MAC Vendor OUI use scheduler
Add command to update `lnms maintenance:fetch-ouis`
Show vendor column in tables if mac_oui.enabled is set to true
Improve scheduler validation handle non-standard install directories and systems without systemd
Add index to table to improve speed and improve mac->vendor lookup speed
Scheduled weekly with random wait to prevent stampeding herd issues for upstream
drop oui update from daily

* MAC Vendor OUI use scheduler
Add command to update `lnms maintenance:fetch-ouis`
Show vendor column in tables if mac_oui.enabled is set to true

* Lint fixes and better prefix detection

* update schema file
2023-08-03 19:29:30 -05:00
Jellyfrog
5a56e9081e
Use Laravel schema migration command directly (#14039)
* Add new schema migration command

* Apply fixes from StyleCI
2023-08-03 19:26:48 -05:00
Tony Murray
77fc6a34df
Graylog API properly throw errors (#15188)
* Graylog API properly throw errors
remove unused legacy graylog code

* Add type casts
2023-08-02 19:59:53 -05:00
Tony Murray
91c57a1ee5
Fix unsanitized input injection (#15184)
Search for and sanitize import that is output to html.
Spurred by report from [Hakiduck](https://huntr.dev/users/mike993/)
2023-08-02 10:37:22 -05:00
Tony Murray
3252ea37af
Fix some xss injection for sysLocation and some other fields (#15183)
Reported by [Zluudg](https://huntr.dev/users/zluudg/)
2023-08-02 09:51:31 -05:00
Zane C. Bowers-Hadley
7505c89586
add generic stats graph munging support and make uptime display as days again (#15097)
* add munging to generic stats graph include

* add graph_uptime_days config def

* make it optionally changable now

* style fix

* remove the graph_uptime_days option
2023-08-02 08:36:25 -05:00
Tony Murray
7265631857
Fix error when there is an untranslated sensor type (#15176)
Will still cause a visual issue, but at least that should indicate a translation is needed.
2023-08-01 12:22:09 +02:00
fufroma
c030b0c00e
RFC1628 - Force cast on some values before doing arithmetic (#14613)
* Force cast on some values before doing arithmetic

Some devices (like Delta InsightPower G3 Mini SNMP Card) return STRING instead of numerical value.

A few lines after, when doing a division on it, everything go bad ( / $divisor).

I added force casting, no more crash and the values are OK.

* Using helper cast_number() instead of intval()

* Fix style

* Add test data

* Stop using deprecated function cast_number
2023-07-31 22:18:26 -05:00
tarik
3541a582bb
fixing the mac/vendor database download from wireshark, updated file … (#15175)
* fixing the mac/vendor database download from wireshark, updated file location and format

* fixing the formatting issues
2023-07-31 22:16:52 -05:00
pjordanovic
98e6fbbe40
added support for the SHARP BP series of MFP (#15169)
added support for the SHARP BP series of MFP
2023-07-28 12:26:26 +02:00
Tony Murray
3908bddb49
Miscellaneous fixes (#15162) 2023-07-26 01:08:10 +02:00
Slashdoom
1f7d5451a2
Add VLAN Discovery for arubaos-cx (#15055)
* add vlan discovery for arubaos-cx

* style fixes

* style fixes

* string interpolation fix

* status walk not used

* add snmprec for 10.10 + vlans

* Create arubaos-cx_10.10.json

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2023-07-24 21:47:46 -05:00
Peter Childs
0b98b6ff72
add os check in discovery for aix/freenas storage and cisco cdp (#15104)
* add os check in discovery for aix/freenas storage and cisco cdp

* use os_group = cisco
2023-07-24 19:07:23 -05:00
Zane C. Bowers-Hadley
40cceee8b4
update SMART monitoring to the use JSON (#15132)
* rework into a json app and support the old style

* working now

* add health checking

* add some datapoints to make writing alerts easy

* add a few missing item for has checks

* rework the app page

* use the right var for id9

* print the self test log if we have it

* add a graph for the max temp

* display the max temp graph

* display the health pass in the disk list if we have the data

* fix legacy handling and set app as ok

* replace id190 and id194 with the more useful maxtemp graph on the apps page

* don't print the additional info area for legacy extends

* add id232

* add id252 graph support

* properly display id232 now

* do not display SSD graphs for non-SSD disks

* for legacy extends, make sure we don't have a bad line

* add missing label for Product value

* fix metrics

* rework the metrics stuff a bit more

* typo fix

* more smart metrics cleanup

* add exit info to metrics

* style cleanup and logic checking for when disks are all now fine

* fix checking for no more health errors

* update the docs for SMART for v1 and remove slightly pointless notes about useSN

* update the docs

* initial test stuff

* add missing tests for the legacy code

* save if it it is legacy or not

* style cleanup

* update the smart legacy test

* style cleanup

* more test tweaking

* some more style cleanup

* more test fixes

* correct the disk ID for the legacy test da0 -> Z304VCFY

* more tests update

* more test cleanup

* begin cleanup of the v1 tests

* more v1 test updates

* more tests for v1

* more test cleanup

* fix exit_nonzero and add unhealthy metric

* add smart alerts

* add the metric unhealthy to the stat test

* use app data for the smart-common.inc.php
2023-07-24 17:03:45 +02:00
Andy Norwood
64c4650801
Add FDB table vendor search drop down (#15072)
* Add vendor search and related functions

* Add OUIDB cache for vendor lookup

* Add vendor drop down

* appy style CI changes

* Apply style CI and lint changes

* more styleCI changes

* update type hinting

* Edit mac_oui cache lock name and function

* Update MAC OUI message during daily

* Use DB for vendor lookup

* New vendor_oui table migration

* New MAC OUI to database function

* Update readbleOUI to use DB rather than cache

* Make StyleCI changes

* styleCI tweak

* Remove lock release to allow refresh timer

* change migration name to match table

* add schema dump

* update schema

* styleCI tweak
2023-07-21 11:30:13 -05:00
fbourqui
a978476cda
Fortigate ipv6 ipsec (#15150)
* Squash Commit
Fortigate Mib updates and ipsc ipv6 tunnels stat
test data to go allong with it

* add optional -Ih flag

* lint fix

* revert changeed on test data 500d

* fix test data on 60f3g4g
2023-07-20 07:50:49 -05:00
Zane C. Bowers-Hadley
54a38dd4cd
add the Mojo CAPE Submit app (#15140)
* add poller for mojo cape submit

* mojo_cape_submit poller now works

* add app page for mojo_cape_submit

* add basic generic stat graphs for mojo cape submit

* general size stats graph for mojo_cape_submit

* make sure we update slugs that did not see anything submitted for them

* sort the slugs by sub count

* add app protos graph and sub top 12 graphs

* add mojo cape submit docs

* add tests for mojo_cape_submit

* add mojo_cape_submit to the apps page

* add string helper for mojo_cape_submit

* poke lots of stuff with php-cs-fixer

* remove a unneeded line

* add a missing metric and app data to test
2023-07-19 22:41:51 -05:00
richard-ririe
4c8e5fc783
Add API endpoint to get service graphs (#15138)
* Add API endpoint to get service graphs

* Docs: Add missing title to get_graph_by_service
2023-07-19 22:19:43 -05:00
hirose003
7cdb81b2e9
change display query to pattern match (#15147) 2023-07-19 22:17:28 -05:00
Zane C. Bowers-Hadley
2ac9a634b4
Logsize monitoring for LibreNMS (#15137)
* add logsize poller

* add set size info

* add more stats

* add min size

* more logsize files

* add logsize

* fix creating log file links

* add two new graphs

* add some graphs

* add no_minus_d

* add no minus d to app page

* add count of log files

* save logsizes in app data

* rename title log sizes

* only show top 12

* add mean median and mode

* cleanup naming a bit

* the values for the files hash is now a int instead of another hash

* add new stats and correct median name

* now properly handle unseen

* fix logsize bits

* add combined

* update metrics and add some tests

* add logsize graphs to apps page

* add the logsize bit

* add logszie docs

* add some example alert rules

* style cleanup

* more style cleanup

* fix a few things for metrics and update the test

* fix a variable name in the test and update the data
2023-07-19 22:02:23 -05:00
Tony Murray
1d7d241894
Add Calix E7 (EXA) PON port sensors (#15145)
* Add Calix E7 (EXA) PON port sensors

* oops

* remove space

* skip sensors on down ports

* fix state generic values

* 10 oid was breaking... change to 8 max

* Add initial divisors... need to double check

* change power to dbm as it is more useful

* Add bias and limits

* Test data

* change skip value
2023-07-17 08:54:04 -05:00
PipoCanaja
dbe0f7f2ca
Fixed invalid IP data in arp-table module (#15142)
Check to catch boggus reply from snmpwalk
2023-07-15 20:45:22 +01:00
AdamB
b27dfa5891
Add support for PrimeKey Software Appliance (#15059)
* Add PK-SOFTWARE-APPLIANCE-V2 MIB

* Add support for PrimeKey Software Appliance

* Move file to correct path

* Make the OS detection more specific

* Thanks vscode

* Sync filename with osname

* Not supported

* Track SQL database size as volume

* Two fixes
2023-07-07 23:35:53 -05:00
tarik
3ad19607d0
adding human readable version of /api/v0/fdb/{mac}/detail (#15045)
* adding human readable version of /api/v0/fdb/{mac}/detail

* adding last seen field in human readable format

* fixing styling issue

* fixing another styling issue

* removing stale variable

* adding a limit to number of results returned in order to limit memory issues

* adding the documentation for fdb_detail api

* Wording fix

* wording fix again. smh

---------

Co-authored-by: Justin Lentz <monkeybrains7@gmail.com>
2023-07-07 23:24:50 -05:00
Peter Childs
b655eb7feb
change chunk to chunkById (#15139) 2023-07-07 11:53:15 -05:00
Peter Childs
7e22b1276a
fix for hrStorageIndex agility (#15028)
* fix for hrStorageIndex agility

* test for array

* Handle not found data

* Handle description changed correctly

* remove debug

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-07-07 11:41:13 -05:00
Nick Peelman
e486ef4c22
Fix MPLS Tab Display for Nokia devices using LDP and not RSVP (#15128) 2023-07-03 13:08:58 +03:00
Elian Manzueta
91acfcc017
Update delhost.inc.php (#15130)
Fixed typo:

monitered->monitored
2023-07-01 14:17:40 -05:00
Sander Blomvågnes
8081a3f3c8
Change state value for unplugged linecard (#15126) 2023-06-28 14:24:59 +02:00
Justin Lentz
2fb73e5f14
Add parenthesis Regex (#15124) 2023-06-27 16:22:40 -05:00
Zane C. Bowers-Hadley
00cf300d1a
add Suricata Extract submission stats app (#15105)
* add suricata_extract

* convert from dervive to gauge and use delta

* add suricata_extract to includes/html/pages/apps.inc.php

* graph cleanup

* add sub_size

* add sub_size graph

* add docs for suricata extract

* add tests for suricata_extract

* add rules for suricata extract

* minor test tweaks
2023-06-25 20:48:26 +02:00
Cyril LAVIER
dc7b702bd8
Add regex for Supermicro switches running firmware 2.0 or newer, now called "SuperSwitch" (#15083)
* Add regex for Supermicro switches running firmware 2.0 or newer, now called "SuperSwitch".

* Add test data for Supermicro MBM switch
2023-06-24 12:22:59 -05:00
Tony Murray
0a3678d11a
Convert several JunOS sensors to yaml (#15118)
* Convert several JunOS sensors to yaml
Fixes some issues with the php code and reduces extra snmp fetches

* Convert several JunOS sensors to yaml
Fixes some issues with the php code and reduces extra snmp fetches

* Convert BER as well
Allow divisor and multiplier to be set from oid

* use fillValues

* fix

* sort snmprec, fix divide by 0, add more context
2023-06-24 11:52:36 -05:00
Zane C. Bowers-Hadley
f84fca697c
add Privoxy stats support (#15114)
* add privoxy

* various style fixes

* cleanup option bar

* save metrics for privoxy now

* add instructions for privoxy

* add privoxy test data

* regen the test data

* add a few missing depends to the instructions

* add apps.inc.php entry for privoxy

* note the required log settings for privoxy

* style fix
2023-06-23 15:27:28 -05:00
Wheel
106219d9cb
APC new sensors (#15090)
* APC Emu dry contacts

* EMU test files

* Added energy and power sensors

* Revert "Added energy and power sensors"

This reverts commit b27b4a3ac2.

* Total energy sensor
2023-06-23 15:08:48 -05:00
mtentilucci
278890ce0a
update mlos-nsp discovery (#15117) 2023-06-23 14:43:03 -05:00
Tony Murray
63fd62ca12
Yaml value filling improvements (#15116)
* Yaml value filling improvements
search all data for fully qualified oids (to prevent incorrect matches)
Reduce searches when not needed
subindex code optimization

* fix aos7

* fix e3meterdc

* Cleanups

* fix hpe-mapdu

* fix timos add note to dev:check

* remove inconsistent Str::contains usage
2023-06-23 13:57:44 -05:00
Zane C. Bowers-Hadley
5da8e70bf4
add Sneck support, making it very trivial to use Nagios style checks in a NRPE like manner (#13954)
* code stuff done for Sneck

* whoops, correct the abs value post adding it post rrd update

* return a array for getting the sneck data and nicely print the raw return value

* add test stuff and freeze time at 1650911765 for tests

* move the freezeTime

* add use Illuminate\Support\Carbon;

* more test changes

* rework freezeTime a bit more

* more test stuff

* another test

* rework it a bit again

* correct variable spelling for $time_diff

* remove freezeTime as we are using a old version of Laravel

* finalize graphs

* misc

* finalize sneck page

* mve the sneck tests as it needs a newer version of laravel than we are using

* add documents for sneck

* finalize the poller

* formatting cleanup

* correct comment type

* correct the spelling of description

* more documentation

* save the check returns as metrics

* add some more examples

* fix some of the sneck alerts and add a few more examples

* turn off time to polling by default

* suggest using ntp if enabled

* since we are zeroing time_to_polling by default, this now works

* backout some suggested changes for once we change to larval 9

* remove del_sneck_data as it is no longer used

* add more docs on the metrics

* php-cs-fixer to fix a few things

* update and fix sneck tests

* remote a metric from the test

* another minor tweak to the test

* one more minor change

* ahh! derp! think I found it finally... hopefully hanging this for the last time...

* now use app data

* now logs check changes

* add a missing )

* add a missing )

* some style fixes

* update the sneck page use to the app data stuff

* update the poller to use the new app data

* misc

* update sneck to log check status changes

* correct alert log messages

* correct a comment

* fix metrics

* derp, another fix

* test fix

* re-order to avoid warning

* poller update

* update sneck graphs

* update sneck graphs

* remove a unneeded line

* test update for discovery

* minor tweaks to the test and fix update the polling a bit

* style fix

* fix return data printing

* fix the test data to include app data

* attempted test fix

* add config def to apps.sneck.polling_time_diff

* cleanup docs a bit

* minor config tweaks

* minor doc cleanup
2023-06-15 09:06:28 -05:00
Justin Lentz
b0ddd4ef15
Extend Avocent Support (#14914)
* Add files via upload

* Update avocent.yaml

* Update avocent.yaml

* Update avocent.yaml

* Update avocent.yaml

* Update avocent.yaml

* Update avocent.yaml

* Update avocent.yaml

* Update avocent.yaml

* Update avocent.yaml

* Update avocent.yaml

* Rename ACS6000-MIB to ACS-MIB

* Update avocent.yaml

* Update avocent.yaml

* Update avocent.yaml

* Update avocent.yaml

* Update avocent.yaml

* Update avocent.yaml

* Update avocent.yaml

* Update avocent.yaml

* Update avocent.yaml

* Create avocent_acs6048.snmprec

* Create avocent_acs6048.json

* Delete avocent_acs6048.json

* Same as avocent_6000

* Point at ACS MIB

ACS-MIB::acsSerialPortTableName

* Update avocent_6000.snmprec

Update avocent_6000 with additional MIB

* Update Test data

* Update avocent_6000.snmprec

* Update avocent_6000.snmprec

* Update avocent_6000.json
2023-06-14 22:50:44 -05:00
Jellyfrog
b14e2d4609
Apply fixes from StyleCI (#15101)
Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-06-13 13:35:00 +02:00
Garcia MICHEL
e547945985
Improve OpenWRT detection (#15096)
* Improve OpenWRT detection

* Add test data

* Remplace openwrt date with new one
2023-06-12 13:59:24 +02:00
Zane C. Bowers-Hadley
0ed68e33de
add Linux Softnet Stat app (#15094)
* add linux_softnet_stat poller

* add graphs and app page for linux_softnet_stat

* fix polling

* rename a few items, clean up the app specific page, and add to the apps page

* convert from derive to counter

* save the budget and budget_usecs to app data

* display current value of the budgets

* now track budget values

* add tests data

* rename it

* add docs for Linux Softnet Stat

* re-order and add budget for app page graph order

* style fix

* correct data location

* fix metrics for the json
2023-06-11 16:37:55 +02:00
Zane C. Bowers-Hadley
3190bdb8b2
add ZFS L2 support (#15095)
* add alerts for ZFS

* add initial l2 bits to the poller for zfs

* more minor tweaks to the ZFS poller

* more zfs bits

* add new ZFS graphs

* begin adding L2 stuff

* add linux_zfs-v3 bits

* update zfs app page

* style fix

* update the data for the zfs legacy test

* test update for zfs v1

* fix some zfs tests

* more zfs v3 test cleanup

* another zfs v3 test data fix

* more zfs v3 test data cleanup

* more test tweaks
2023-06-11 16:32:28 +02:00
kg6uyz
1ba544c2ef
Update Trendnet TEG-S50ES and TPE-P521ES OS detection (#15052)
Add OID's for TEG-S50ES and TPE-P521ES switches to be detected as Trendnet devices instead of generic devices.
2023-06-05 16:48:36 +03:00
wrongecho
ea57c25182
Remove asterisk from recurring input (#15074) 2023-05-30 18:49:12 -05:00
Jellyfrog
2b3575a5e9
Laravel 10.x Shift (#14995)
* Apply code style

* Remove explicit call to register policies

* Shift core files

* Shift config files

* Default config files

In an effort to make upgrading the constantly changing config files
easier, Shift defaulted them and merged your true customizations -
where ENV variables may not be used.

* Bump Laravel dependencies

* Add type hints for Laravel 10

* Shift cleanup

* wip

* wip

* sync translation

* Sync back config

* Public Path Binding

* QueryException

* monolog

* db::raw

* monolog

* db::raw

* fix larastan collections

* fix phpstan bug looping forever

* larastan errors

* larastan: fix column type

* styleci

* initialize array

* fixes

* fixes

---------

Co-authored-by: Shift <shift@laravelshift.com>
2023-05-24 22:21:54 +02:00
d-k-7
dd3ed41319
add sensor support for cefcModuleOperStatus (#15026)
* add sensor support for cefcModuleOperStatus

* add tests for cefcModuleOperStatus

* revert sensors/state/cisco.inc.php

* add sensor support for cefcModuleOperStatus using yaml

* update tests for cefcModuleOperStatus

* try adding tests again for cefcModuleOperStatus

* include CISCO-ENTITY-FRU-CONTROL mib for cefcModuleOperStatus sensor state discovery
2023-05-24 20:43:37 +02:00
Jellyfrog
153be4d583
Tests: Fix Dusk tests after 13626 (#15057) 2023-05-23 19:23:15 +02:00
Tony Murray
04bb75f5f3
Alert transport cleanup, no_proxy support and other proxy cleanups (#14763)
* Add no_proxy and other proxy related settings
Set user agent on all http client requests
Unify http client usage

* Style fixes

* Remove useless use statements

* Correct variable, good job phpstan

* Add tests
fix https_proxy bug
add tcp:// to the config settings format

* style and lint fixes

* Remove guzzle from the direct dependencies

* Use built in Laravel testing functionality

* update baseline
2023-05-23 09:25:17 -05:00
Nick Peelman
da94ac5a85
Add RoomAlert 12E Switch Sensors, fix Humidity Sensor (#15049)
* Add RoomAlert 12E Switch Sensors, fix Humidity Sensor

* Fix per murrant

* Revert port data generated on older install

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-05-19 10:14:09 -05:00
mtentilucci
e55c4e9e1e
Add support for Trellix NSP devices (#14964)
* Add support for Trellix NSP devices

- Add discovery for mlos NSP devices
- Monitor port statistics from non standard MIBs
- Add Trellix MIBs
- Add test data

* Fix StyleCI findings

* Rename MIB files to match MIB names, remove unused MIBs

* regenerate mlos-nsp_ns9500.json to account for changes from PR#14963
2023-05-16 17:25:29 -05:00
Albert Siersema
ad1b2f96f5
Fixes #14957 missing IPv6 BGP peers (#14959)
* Fixes #14957 missing IPv6 BGP peers

* Limit to NX-OS and IOS-XR

* Check for actual VRF since count(getVrfContexts) always > 0

* argh, fix last minute nervous finger superfluous space

* removed redundant count()
2023-05-15 10:32:26 +02:00
Dominik V. Salonen
26c49af32d
rutos-rutx: Map GPS lat and lon to os module (#15033)
Makes GPS position appear on geographic maps.
2023-05-12 07:45:48 -05:00
Nick Peelman
6247eeae36
Fix inventory display for Calix AXOS devices (#15039) 2023-05-12 07:06:34 -05:00
Nick Peelman
09b3c88ae0
Fix WISI over graphs (#15040) 2023-05-11 22:51:12 +02:00
Tony Murray
3315b5d0f8
Remove old unused adduser page and script (#15035)
Use /users/create and lnms user:add instead
2023-05-11 02:32:20 +02:00
Neil Lathwood
2f6904fb59
webui: Fix availability graphs to 100% (#15013)
* Fix availability graphs to 100%

* Update availability.inc.php
2023-05-10 22:03:51 +01:00
cjsoftuk
635acad7d6
Firebrick CPU Monitoring (#15030)
* Add FB CPU definition.

* Poll in the right OID.

* Add test data for FB CPUs.
2023-05-09 17:32:34 +02:00
eskyuu
ce0734ff5d
Added support for user timezones and user browser timezone by default (incomplete) (#13626)
* Added support for user timezones and user browser timezone byt default

* Formatting fixes

* Use the timezone for alert log display

also added validation for the timezone because it's being used in SQL.

* Formatting fixes

* Added return type

* Formatting"

* Update the latency graphs to use the user timezone

* Simplify the web routes config

* Update phpstan to ignore type error

* Fixed up the phpstan config

* Reverse phpstan change

* Re-apply phpstan override

* Remove the option to unset the session timezone

* Formatting fix

* Update outge and event logs to use session timezone

* Fix route for the timezone control

* Made the timezone more dynamic

* Fix a logic error that was stopping the timezone from being set automatically on login

* Prevent getPref from being called twice

* again prevent getPref double call

* getPref double call

* Fixed typo made during merge

* Fixed merge error in phpstan-baseline.neon

* Change spaces to tabs in phpstan-baseline.neon

* Update error count

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-05-09 10:24:48 -05:00
bnerickson
56e9fa3742
Adding linux_config_files application support (#14776) 2023-05-09 10:23:49 -05:00
cjsoftuk
927446db7b
Fix Firebrick mempool polling (#15022)
* Add support for Firebrick memory monitoring.

* Add mempool testing for Firebrick.

* We have to specify the OID by numeric, because otherwise it assumes it's some kind of indexed table.

* Specify by OID.

* Fix test result data for the FB mempools.x

* Firebrick reports in KB.

* Fix precision in the tests.
2023-05-02 14:02:50 -05:00
cjsoftuk
bc310cffec
WIP: Add support for memory monitoring on Firebrick platform (#15021)
* Add support for Firebrick memory monitoring.

* Add mempool testing for Firebrick.
2023-05-02 07:12:09 -05:00
Shao Yu-Lung (Allen)
741d93c2a5
feat: Agent support OS Updates (#14687) 2023-04-28 08:49:04 -05:00
jlo-lirmm
41ae162223
php implode arg mismatch (#15014)
php implode arg mismatch
2023-04-28 15:44:22 +02:00
Tony Murray
5c25cece48
Convert the inventory page to Laravel (#15004)
* Convert the inventory page to Laravel
Fix several XSS issues (hopefully no new ones snuck in)
Small improvement to the SelectController to allow filtering by filterFields()

* style fixes

* Fix lint issues

* Fix part device filter
2023-04-28 07:51:41 -05:00
Mathias Bøhn Grytemark
204abe0cf2
add advantech icr-os for advantech routers (#14171) 2023-04-25 07:54:41 -05:00
Justin Lentz
8c96a391c9
Clarify Alert Notify Settings (#14974)
* Update print-alert-rules.php

* Update print-alert-rules.php

Was hoping to avoid word wrap with notify, but can't be avoided, so changing to notification
2023-04-24 18:57:13 -05:00
Tony Murray
e1b6fd0165
Fix more refactor errors (#14998) 2023-04-23 20:33:50 -05:00
Tony Murray
2271e29e03
Fix billing error introduced by #14979 (#14996)
Fixes #14994
2023-04-23 13:23:54 -05:00
Tony Murray
265906b44c
Fix some undefined constants (#14993)
* Fix undefined constants
These have been broken for a long time.  Likely they are unused.

* Fix undefined constants
These have been broken for a long time.  Likely they are unused.
2023-04-22 10:37:20 -05:00
Tony Murray
3fe3db747c
Refactor billing (#14979)
* Refactor common billing code into a namespace
Prevents issues of usages where the code hasn't been loaded.

* remove redundant Billing in method names

* remove accidental duplication

* more use statements

* Style fixes
2023-04-21 19:52:47 -05:00
Tony Murray
2ddfba51dd
Set ping_perf scale_min to 0 (#14989)
And allow scale_min, scale_max, and scale_rigid to be set via url parameter
2023-04-20 22:30:32 -05:00
ollb
d40c3be75d
Fix cisco dbm sensors port link on discovery (NCS55A2) (#13965)
* Fix cisco dbm sensors port link on discovery (NCS55A2)

dBm sensors were not linked to port on Cisco NCS55A2 platform (iosxr)
causing false alarms triggered by optical modules in administratively shut down ports.

* Delete iosxr_ncs55a2.json

* Create iosxr_ncs55a2.json

* Renew test/data/iosxr_ncs55a2.json

* Delete and recreate test/data/iosxr_ncs55a2.json

With command :

  ./scripts/save-test-data.php -o iosxr -v ncs55a2 -m os,ports,processors,mempools,sensors

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-04-17 11:08:52 -05:00
Jellyfrog
0a351b49fd
Laravel 9.x Shift (#14504)
* Move `resources/lang` folder

* Shift registered middleware

* Remove `fruitcake/laravel-cors` dependency

* Streamline `$commands` property

* Upgrade to Flysystem 3.0

* Shift core files

* Convert `optional()` to nullsafe operator

* Remove unnecessary `$model` property

* Convert route options to fluent methods

Laravel 8 adopts the tuple syntax for controller actions. Since the old options array is incompatible with this syntax, Shift converted them to use modern, fluent methods.

* Convert deprecated `$dates` property to `$casts`

* Shift config files

* Default config files

In an effort to make upgrading the constantly changing config files
easier, Shift defaulted them and merged your true customizations -
where ENV variables may not be used.

* Bump Laravel dependencies

* Use `<env>` tags for configuration

`<env>` tags have a lower precedence than system environment variables making it easier to overwrite PHPUnit configuration values in additional environments, such a CI.

Review this blog post for more details on configuration precedence when testing Laravel: https://jasonmccreary.me/articles/laravel-testing-configuration-precedence/

* Fix error provider

* Match new symfony syntax

* Match upstream syntax

* Fix route syntax

* generate composer.lock

* Sync back configs

* routes

* composer

* Fix more flare

* fix cors

* sync lang

* Apply fixes from StyleCI (#14517)

Co-authored-by: StyleCI Bot <bot@styleci.io>

* bump larastan

* update packages

* wip

* Temporarily lower phpstan level

* Update phpstan.neon

* wip

* wip

* wip

* Apply fixes from StyleCI (#14592)

Co-authored-by: StyleCI Bot <bot@styleci.io>

* test

* Update CiHelper.php

* Update test.yml

* Update CiHelper.php

* Update CiHelper.php

* Apply fixes from StyleCI (#14616)

Co-authored-by: StyleCI Bot <bot@styleci.io>

* test?

* fix phpstan problems

* dont run snmpsim on github ci

* Fix whitespace

* More whitespace

* More whitespace ???

* I think the space broke it

* fix the reset of the whitespace

* hard code auth guard

---------

Co-authored-by: Shift <shift@laravelshift.com>
Co-authored-by: StyleCI Bot <bot@styleci.io>
Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-04-17 06:51:35 -05:00
AdamB
519fc00367
Change ESXi port naming to be stable (#14639)
* Change ESXi port naming to be stable

Currently every time discovery runs against ESXi, the port names change generating a lot of log spam.

This is because ESXi uses this as the ifDescr:
```Device vmnic1000202 at 01:00.0 nmlx4_en```

The poller parses this, and extracts the interface name, whereas discovery does not, causing the interface names to flip every 6 hours.
https://github.com/librenms/librenms/blob/22.10.0/includes/polling/ports.inc.php#L578-L580

This change gives the discovery process the same behaviour, so the naming is now stable.

* Try to fix test data with a squash

* vcsa test data

* Synthesise VCSA ifName, use it in place of ifDescr

* Refresh test data

* Update ports.inc.php

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-04-16 12:58:38 -05:00
Tony Murray
a70d10af19
Fix vsolution discovery yaml (#14970)
* Fix vsolution discovery yaml
Fetching too much data and incorrect config for scalar values.

* revert json changes

* one sensor_prev

* fix

* revert all changes
2023-04-14 23:11:01 -05:00
Stef
0430f6acb1
Cisco QFP polling fixes (#14961)
* fix cisco-qfp Division by zero

* fix percentage calc

* linting

* another zero in RRD. the (int) might be consequential errors and should hurt...

* no float for average_package

* Update includes/polling/cisco-qfp.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>

* Add floor

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-04-14 22:11:36 -05:00
mtentilucci
b6572e0acc
Add support for Trellix ATD devices (#14965)
* Add support for Trellix ATD devices

- Add discovery for mlos ATD devices
- Monitor various OIDs related to ATD system health and status
- Add required MIBs
- Add test data

* add json test data

* Rename MCAFEE-SMI to MCAFEE-INTRUVERT-SMI

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-04-14 19:34:43 -05:00
Tony Murray
6a769fc7a4
Fix Tait Tnadmin Processor discovery (#14969) 2023-04-14 18:26:38 -05:00
Schylar Utley
056305c3c3
Add support for Alpha CXC HP Controller (#14829)
* add support for Alpha CXC HP Controller

* add num_oids, fix formatting

* fix typo

* Rename cxc_cxc.snmprec to cxc.snmprec

* Create ALPHA-RESOURCE-MIB

* Create ALPHA-RECTIFIER-SYS-MIB

* Create cxc.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-04-14 18:04:42 -05:00
Kevin Zink
5d7b0e8dc8
Correct PowerConsumed SI Units in Overview (#14425)
* Correct PowerConsumed SI Units in Overview

Workaround to convert PowerConsumed SI Display Units from kkWh to MWh. Better way would be to directly save the data in Wh instead of kWh. But we don't know the impact jet.

* Fix style
2023-04-14 17:34:03 -05:00
Tony Murray
0cdda100e7
Fix Raisecom Processor (#14968)
* Fix Raisecom Processor
Had the same problem as ROS #14966

* Missed oid update
2023-04-14 17:12:35 -05:00
Justin Lentz
b9cc630dbc
Stacked graphs on zoom to speed (#14928)
* Update generic_data.inc.php

* Update functions.inc.php

* Update generic_data.inc.php

* Update functions.inc.php

* Update functions.inc.php

* Update generic_data.inc.php

* Update graphs.inc.php

* Make Murrant Happy ;)

* Update generic_data.inc.php

* Update generic_data.inc.php

* Update graphs.inc.php

* Update graphs.inc.php
2023-04-14 16:48:30 -05:00
Tony Murray
cafdec6285
Remove unused port fields (#14963)
* Remove unused port fields
(and set vlan to default to null)

* Update test data for deleted fields

* update vlan to null

* missed field removals

* More correct migration

* Update new data

* restore accidental deletions
2023-04-14 16:47:26 -05:00
Tony Murray
49056da4a0
Fix Raisecom ROS processor collection (#14966)
Was origionally intended to use the 1 minute values, but was discovering the one second value and polling the twoHour value
Was also restricted to only one CPU.
Now discovers and polls all CPUs at the oneMin avg
2023-04-14 15:22:55 -05:00
mtentilucci
04217269a4
Expand discovery of gigavue os (#14933)
* Expand discovery of gigavue os

- Expand discovery so all Gigamon products are discovered
- Query for hardware version using GIGAMON-SNMP-MIB::model.0 OID if present
- Add more Gigamon gigavue test data

* Create gigavue_hc2.json

Looks like there was no json file before...

* update gigavue_hc2.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-04-14 07:12:44 -05:00
JStandiford
3362e0ee7b
fortivoice: add version, hardware and serial collection (#14956)
* Update fortivoice.yaml

Add in pulling in device hardware and software info

* Add files via upload

* Add files via upload

* merge test data

* Delete fortivoice_fortivoice.snmprec

* Update fortivoice.json

* Update fortivoice.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-04-12 10:11:49 -05:00
Tony Murray
e9c08e21a5
Fix more divide by zero issues (#14954)
* Fix more divide by zero issues
fixes: 14932

* Round to the nearest integer, then cast

* Fix up dhcpatriot
2023-04-11 13:44:45 -05:00
pjroehl
2b1f6a743d
Add discovery of NVT Phybridge FLEX24 (#14913)
* Add discovery of NVT Phybridge FLEX24

* Update phybridge-flex.yaml

Added FLEX-24 Switch under sysDescr

* Test Data phybridge-flex_flex-24 json and snmprec
2023-04-10 11:12:12 +02:00
PipoCanaja
228c4ca78d
bug - wrong type in ports.inc.php (#14952)
Yet another of these :) 

```
[2023-04-07T19:55:28.777810+02:00] production.ERROR: Error polling ports module for xxxxxxxxxx. TypeError: Unsupported operand types: string - int in /opt/librenms/includes/polling/ports.inc.php:785
Stack trace:
#0 /opt/librenms/includes/polling/functions.inc.php(339): include()
#1 /opt/librenms/poller.php(126): poll_device(Array, false)
#2 {main}  
[2023-04-07T19:55:28.780705+02:00] production.ERROR: Unsupported operand types: string - int {"exception":"[object] (TypeError(code: 0): Unsupported operand types: string - int at /opt/librenms/includes/polling/ports.inc.php:785)"} 
```
2023-04-07 14:09:57 -05:00
Tony Murray
3380122733
Poller perf: add per device average (#14940)
* Poller perf: add per device
Fix min, avg, and current values

* Fix up previous

* Fix style

* Rename to device average, we don't calculate min and max, but rather the min/max of the average.
2023-04-07 13:27:12 -05:00
mtentilucci
b09f5f63e4
Add Nutanix AOS discovery (#14950)
* Add Nutanix AOS Discovery

- Add basic discovery configuration
- Add Nutanix .svg icon and logo
- Add test data

* fix yaml style nutanix-aos.yaml
2023-04-07 13:02:41 -05:00
mtentilucci
698b9ee48c
Add Rubrik Discovery (#14951)
- Add basic discovery
- Add Rubrik .svg icon and logo
- Add test data
2023-04-07 13:01:30 -05:00
Tony Murray
8809779b82
RouterOS runtime quirk on first discovery (#14945)
(assume version is > 6.47 if it isn't fetched yet)

fixes #14935
2023-04-06 21:09:31 -05:00
Justin Lentz
df31be30c1
Cleanup enable bgp setting (#14931)
* remove logic in module

* remove enable_bgp logic

* remove enable_bgp logic

* remove enable_bgp logic

* remove enable_bgp logic

* remove enable_bgp definition

* remove enable_bgp logic

* Remove enable_bgp documentation

* StyleCI

* StyleCI

* StyleCI

* StyleCI

* StyleCI

* StyleCI

* StyleCI

* StyleCI

* StyleCI

* StyleCI
2023-04-06 21:01:21 -05:00
cjwbath
bbe752b24a
Add initial OS detection for LoadBalancer.org (#14902)
* Add initial OS detection for LoadBalancer.org

* Match on Linux sysObjectID first for efficiency

Co-authored-by: Tony Murray <murraytony@gmail.com>

* Add test for loadbalancer OS detection

* Add test for loadbalancer OS detection - fix author

* Add test for loadbalancer OS detection

* Add test for loadbalancer OS detection - fix author

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
Co-authored-by: Chris Ware <cjw26@bath.ac.uk>
2023-04-06 19:58:14 -05:00
Dan Baker
a340672e86
Added graphing of DDoS-protection related OIDs for PAN-OS (#14847) 2023-04-06 19:11:16 -05:00
Dan Baker
7173205039
Added sensor support for older APC InfraStruXure PDUs (#14944) 2023-04-06 19:09:45 -05:00
torbeckattsp
13d8ac222d
Update hikvision-cam.yaml (#14943)
Hikvision cameras model number does not forcibly starts with 'DS-' anymore.
Here is an sample of a OEM new model made by HIKVISION 
[
.1.3.6.1.4.1.39165.1.1.0 = STRING: "IPC7A27-ANPR"
.1.3.6.1.4.1.39165.1.2.0 = STRING: "0"
.1.3.6.1.4.1.39165.1.3.0 = STRING: "V5.7.80 build 220525"
.1.3.6.1.4.1.39165.1.4.0 = STRING: "98-f1-12-c7-0b-a2"
.1.3.6.1.4.1.39165.1.5.0 = STRING: "88"
.1.3.6.1.4.1.39165.1.6.0 = STRING: "IPcamera"
.1.3.6.1.4.1.39165.1.7.0 = STRING: "38 PERCENT"
...]
2023-04-05 21:05:59 -05:00
electrocret
8e5f26652e
Indicator on Port Notes tab when Port has notes (#14923)
* Update port.inc.php

* Use Port Object
2023-04-05 15:52:13 -05:00
d-k-7
14f19eb6cf
APC UPS UIO sensor discovery bug (#14942)
* only proceed if there are entries in the uio table

* only proceed if there are entries in the uio table
2023-04-05 22:48:23 +02:00
RobJE
75033daaa8
add support for WTI console products (#14920)
* add support for WTI console products

* add test data
2023-04-04 13:21:10 +02:00
GeantRA
ec9e77b665
Update junos discovery yaml to reference total memory instead of buff… (#14919)
* Update junos discovery yaml to reference total memory instead of buffer memory used

* Add FPC0 test data reference
2023-04-04 10:28:59 +03:00
mtentilucci
d508d2d6f3
reorder command to follow documented syntax (#14910) 2023-03-30 14:04:06 -05:00
kirk444
0a889ad363
Add additional 7130 devices (#14922)
Add additional sysObjectID for additional MOS / 7130 models.
2023-03-24 02:29:53 +01:00
jellejans
ae429d987a
Device - Add support for Scalance SC646-2C (#14835)
* Update scalance.yaml

Add support for Scalance SC646-2C

* add scalance_sc646.snmprec
2023-03-21 07:31:42 -05:00
Stef
e1b2a42373
Device: Deltanet Lambdatrail LT2-S,HS (#14661)
* Deltanet Lambdatrail integration - first try

* add fan parameters

* ignore values

* lint

* over graphs and snmp fix

* definition for hs variant

* HS variant added

* mibs renamed

* add test data

* Deltanet Lambdatrail integration - first try

* add fan parameters

* ignore values

* lint

* over graphs and snmp fix

* definition for hs variant

* HS variant added

* mibs renamed

* add test data
2023-03-21 07:29:17 -05:00
Nick Peelman
7ccccdf914
Add Montclair EDFA Support (#14852)
* Add Montclair EDFA Support

* Fix detecton

Used explicit match regex

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-03-18 21:34:28 -05:00
pjroehl
bbabf4bf36
Added cisco FTD 1150 to ftd.yaml (#14907)
* added cisco FTD 1150 to ftd.yaml

* Added cisco FTD 1150 to ftd.yaml

* Added Cisco FTD 1150 to ftd.yaml
2023-03-18 18:54:06 +01:00
mtentilucci
d6d2827f97
Add support for Trellix FireEye OS (#14908) 2023-03-18 18:51:14 +01:00
Marek Wobst
cfb70f73d1
Add more OIDs for determining hardware and serial attributes correctly (#14904)
Some FTD systems like 4110 and 4120 (probably more) use different OIDs (not .1 or .4) for that, so these were added. The version extension is probably not helpful, as the result is an empty string … but at least that OID exists.
Not: without this change, hardware+serial fields will be empty after a (re)discovery.
2023-03-16 16:05:23 +01:00
Stef
82bd437e47
Syslog sink over http for logstash (or any json source) (#14424)
* inital commit of a new syslog sink over http

* cosmetics

* cosmetics fix...

* cosmetic fix again

* cosmetics fix again

* its nice now...

* add non blocking option

* Syslog Sink integrated as API PUT method

* lint fix

* Update includes/html/api_functions.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>

* Update includes/html/api_functions.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>

* Update includes/html/api_functions.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>

* change to POST, fix decoding issue and json exception

* logstash/json documentation added. syslog documentation a bit re-structured

* lint fix

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-03-15 08:14:38 -05:00
electrocret
1173cf3161
Fix dbm calculation to return -60 instead of 0 (#14858)
* Fix calculation

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9010.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* rebuild using SNMPRec

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9010.json

* Update iosxr_asr9901.json

* Update iosxr_asr9001.json

* Update iosxr_asr9010.json

* Update iosxr_asr9901.json

* Update iosxr_asr9010.json

* Update iosxr_asr9001.json

* Update iosxr_asr9010.json

* Update iosxr_asr9901.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9001.json

* Update iosxr_asr9010.json

* Update iosxr_asr9901.json
2023-03-15 08:07:46 -05:00
Jellyfrog
68e0b3df28
Apply fixes from StyleCI (#14899)
Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-03-13 22:32:22 +01:00
Stef
0e322ae5d5
Pseudowires refresh (#14882)
* refresh the pseudowires

* linting
2023-03-13 10:19:23 -05:00
Tony Murray
d3f02e6bb7
SnmpQuery, respect snmp.max_oid (#14894)
Previously, the code would query all the oids it received. Now it will split it up into multiple queries if too many are sent.

Prevents some devices snmp service from crashing.
2023-03-13 10:17:34 -05:00
Jellyfrog
e9f8e64506
Re-throw exceptions if we're in CI (#14890)
Else they are not shown during tests
2023-03-10 15:00:03 +01:00
Jellyfrog
f111ac22fe
APC: Add support for Battery Recommended Days Remaining (#14653)
* APC: Add support for Battery Recommended Days Remaining

* Extract number from string later during polling
Odd that this is different from the discovery process

* wip

* wip

* Apply fixes from StyleCI

* wip

* wip

* Apply fixes from StyleCI

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-03-10 14:50:56 +01:00
Marek Wobst
58acfe8f92
Add Cisco FTD Support for security appliances (#14893)
Models: 4110, 4120, 4125 (each with K9)
2023-03-10 14:47:37 +01:00
mtentilucci
1e373dedc6
Add Avocent MergePoint Unity KVM Switch Support (#14874)
* Modify Avocent discovery so Avocent MergePoint Unity KVM switches are discovered

* Extract hardware model and version stored in sysDescr OID

* add avocent mpu snmprec

* add json dump test data

* update to not conflict with dell-rcs discovery

* fix styleci findings

* update Avocent.php

* update Avocent.php

* add support for avocent mp unity kvm switches

* add support for avocent mp unity kvm switches

* add support for avocent mp unity kvm switches

* add support for avocent mp unity kvm switches

* add support for avocent mp unity kvm switches

* add support for avocent mp unity kvm switches

* cleanup

* fix os name typo

* Add support for Vertiv Avocent MergePoint Unity

- Remove unnecessary sysdescr_regex in discovery file
- Only show device_bits graph in device header bar
- Use Vertiv icon
- Replace .png Vertiv icon and logo with .svg
- Disable unnecessary discovery and poller modules
- Add more snmpsim test data

* Update avocent-mp.yaml

Only disable poller and discovery modules if they cause problems
2023-03-10 00:09:53 +01:00
Zane C. Bowers-Hadley
cd82c72190
add graph_stat_percentile_disable config item to disable percentile lines/value printing (#14887)
* add the initial config items for graph_stat_percentile_disable

* update generic stats to use graph_stat_percentile_disable

* style fix
2023-03-09 17:24:32 +01:00
Zane C. Bowers-Hadley
6b56e781b1
actually use the stats graph for ntp-server_freq now (#14884) 2023-03-09 13:32:19 +01:00
Zane C. Bowers-Hadley
2a53c49a5c
convert NTP freq to use generic_stats (#14834) 2023-03-09 00:23:31 +02:00
electrocret
d7a7e0c158
Improve Corero CMS support (#14876)
* MIBs

* Create cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Add files via upload

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Update cms.yaml

* Add files via upload

* Update cms.snmprec

* Update cms.json

* Update cms.json

* Update cms.json
2023-03-04 19:00:31 +01:00
electrocret
b68aa04311
Add Fortigate Webfilter stats (#14873)
* Update fortigate.yaml

* Update fortigate.yaml

* Fix git-apply

* Create fortigate_webfilter.snmprec

* Update fortigate_webfilter.snmprec

* Create fortigate_webfilter.json
2023-03-03 18:22:58 +01:00
Luke Wurl
de16bbdc49
Add Cisco FTD 4112 Support (#14872)
Add sysObjectID for FP4112
2023-03-03 14:06:28 +01:00
Zane C. Bowers-Hadley
a0f1dab07b
add type checking to generic_stats.inc.php for $vars['to'] and $vars['from'] (#14871)
* make sure the $vars['from'] and $vars['to'] are actually numeric

* style fix
2023-03-02 22:59:31 +01:00
Zane C. Bowers-Hadley
19278bf19f
update fail2ban to have better stat graphs and and fix generic_stats graph.php (#14818)
* update fail2ban better stat graphs

* style fix

* add rainbow color pallete

* cleanup colors and make it more easily understandable via using the new rainbow colour pallete

* a bit more color tweaking

* green is easier on the eyes

* style fix

* fix hgandling for smaller graphs for some things

* for <= height graphs, use area

* rework the area bit and add a alpha

* style cleanup

* more style cleanup

* mm... colourA does work a lot nicer if the same as colour

* add two more palletes and make the purple the default

* only include 1d once as that as some versions of rrd break if it is twice

* move time_diff to the proper location
2023-03-02 18:51:16 +01:00
Dan Baker
cd7aa5e65d
Added PoE controller load and status sensors for Junos devices (#14868) 2023-03-02 11:16:54 +02:00
not-known
dda3176131
Add Fortigate packet loss monitoring for Link-Monitor and SD-WAN; Remove testing of VPN config from the SD-WAN tests as it is unrelated and could break the test (#14828)
Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
2023-03-01 01:10:45 +01:00
Henne Van Och
2140ff21c5
add more docker stats (#14767) 2023-03-01 01:02:01 +01:00
Zane C. Bowers-Hadley
f023d37cfc
update various device graphs to to have better stats (#14815)
* update graphs -> systems page

* update availability graph to use the stats graph for 1 day averages

* a bit of cleanup for various graphs

* a few style fixes I missed

* another style fix

* update the pingperf graph as well

* update the poller perf graph as well

* style fix

* move graphs to using generic_stats default for readability
2023-03-01 01:00:13 +01:00
Mark Westerterp
d4556bdda5
Fix graphs for a search query (#14864) 2023-02-28 22:39:38 +01:00
electrocret
ef1b54b265
Fix interface parse unsets (#14860) 2023-02-24 08:49:36 +01:00
electrocret
a21c6ec91c
Use Device displayname on VRF page (#14851)
* Use displayname

* Style

* Style
2023-02-21 00:40:18 +01:00
electrocret
b6df8b0116
Fortigate IPS Intrusions detected stats (#14857)
* Update fortigate.yaml

* Use IPS stats table

* Update fortigate.yaml

* Update fortigate.yaml

* Update fortigate.yaml

* Update fortigate.yaml

* Update fortigate.yaml

* Test data

* Update fortigate_ips.snmprec

* Potential for multiple entries.

Further testing found some firewalls with multiple table entries.

* cleanup display

* Update fortigate.yaml

* Update fortigate.yaml

* Update fortigate.yaml

* Update Testdata
2023-02-21 00:39:20 +01:00
Guilherme Poletto
5dc7f89922
Add support for Vsol v1600d EPON OLT (#14853)
* Add Modified V-sol MIB

* Add Vsolution Discovery OS

* Add Vsolution Discovery OS

* Add os-logo

* Add snmp test data

* Add .json test data

* Add .json actual test data
2023-02-20 12:31:43 +01:00
Floris Van der krieken
f2dfe2f928
Fix discovery for apc ats (#14837) 2023-02-09 09:36:10 +01:00
Andy Norwood
3023aa7e0f
API: add display query to list_devices function (#14747)
* add display query type

* add display to query examples

* fix typo
2023-02-08 18:36:20 +02:00
Kyle Gordon
ad624b1093
Include Samsung X Series printers (#14831)
Tested against X7600 and X4300. Both of which change from being a generic device to a Samsung printer device. Subsequent poller.php runs result in toner, fuser, impressions counts, etc data being returned.
2023-02-07 23:12:50 +01:00
electrocret
1e5e26492e
Use Oxidized API client and add support for groups on config get (#14750)
* Use API client and add support for groups.

* Being Stylish.

* Update incorrect doc
2023-02-01 11:49:29 -06:00
Zane C. Bowers-Hadley
653da5a3f0
update HV::Monitor support to use generic_stats.inc.php (#14814) 2023-01-29 20:54:00 +00:00
Zane C. Bowers-Hadley
ae6ba985e4
Add a few more graphs for CAPEv2 (#14813) 2023-01-29 20:51:58 +00:00
Tony Murray
2f6d375652
Revert "Fix entity-state polling/discovery (#14793)" (#14811)
This reverts commit ebbb7cbdcf.
2023-01-27 00:43:45 +00:00
Noah Roufus
7abdc5b914
EdgeOS OLT new sensors and changes (#14807) 2023-01-26 15:21:25 +00:00
electrocret
d01538dd8f
Show display name in Oxidized config search (#14800) 2023-01-26 15:18:55 +00:00
electrocret
08b025c1b8
Only show Eth errors when Etherlike is enabled (#14784) 2023-01-24 11:31:34 -06:00
Zane C. Bowers-Hadley
98c033e84f
CAPEv2 support (#14801)
* re-add it

* add cape app page

* add initial cape graphs

* now work for the general page

* more udpates

* add cape pending

* add pending and cleanup for if there are no packages(likely cuckoo, so don't add extra items)

* rework the lack of packages a bit more

* more cuckoo related cleanupgiot

* fix cape error logging

* minor cleanups

* add a new graph and use it with cape... also lots of cape cleanups

* misc cape updates

* add percentile values for stats

* add fix for weekly

* don't display 1 day average if under 17 hours

* zero timeslots of packages not used for this time slot

* add avg stat graphs for cape

* now use the average graphs and update the app page

* add a new graph

* add CAPEv2 docs

* add tests data

* lots of style cleanup

* another tweak for the test data

* fix misc style issues

* add cape to apps page

* add nicecase for cape

* case fix

* json fix for test data

* add a missing stat

* some more test data tweaking

* more misc test updates

* more test tweaking

* more test work...

* more test data work

* add what is hopefully the final test tweak
2023-01-24 11:20:18 -06:00
PipoCanaja
c2b0a6ed80
Extend filtering of graphs device_bits on cisco ASA (#14796)
* Extend filtering for device_bits for cisco ASA

* Style
2023-01-24 11:15:59 -06:00
electrocret
309a9be3b6
Use displayname instead of hostname for Device Maintenance Modal Title (#14681)
* Use displayname instead of hostname

* Update device_maintenance.inc.php

* Update device_maintenance.inc.php

* Update device_maintenance.inc.php

* Update device_maintenance.inc.php

* Update device_maintenance.inc.php

* Update device_maintenance.inc.php

* Update device_maintenance.inc.php

* Update device_maintenance.inc.php

* Update device_maintenance.inc.php

* Update device_maintenance.inc.php
2023-01-20 16:37:50 +01:00
carbinefreak
d869b879d1
Nokia PMC Microwave Improvements (#14761) 2023-01-19 23:31:57 +01:00
jaannnis
ff89f7b87f
ISE: added Support for SNS-3615-K9 (#14792) 2023-01-19 23:30:18 +01:00
Daniel Meyer
852e1c5d47
Changed discovery OID in ets.yaml (#14795) 2023-01-19 16:00:21 +01:00
fdomain
ebbb7cbdcf
Fix entity-state polling/discovery (#14793) 2023-01-19 15:14:29 +01:00
Knut Petter Ølberg
4a97c67b92
Routeros lldp discovery (#14791) 2023-01-18 18:46:36 +01:00
dennypage
7936c7daf2
Add Universal Input Output support for APC (#14766) 2023-01-10 16:25:16 +01:00
Nick Peelman
3cda342581
Eaton matrix wattage fix (#14770) 2023-01-10 16:13:53 +01:00
electrocret
96e1350b9d
Fix cisco-flash (#14772) 2023-01-05 02:03:17 +01:00
electrocret
56f13f1a13
Fix calculated dbm (#14771) 2023-01-04 19:13:52 +01:00
not-known
dc74ba03ae
Add state of the Fortigate link monitor health checks (#14675) 2023-01-04 16:41:25 +01:00
Sander Blomvågnes
cf3f69e67f
Adding support for loop-telecom devices (#14674) 2023-01-02 14:47:17 +01:00
bnerickson
bf25313d3c
Adding discovery of LSI MegaRAID Device Media Errors, Other Errors, a… (#14729) 2023-01-02 11:57:35 +01:00
Nick Peelman
d21d4422b4
Add AXOS sensor data for PON Transceivers (the only transceivers Cali… (#14741) 2023-01-02 11:24:59 +01:00
Nick Peelman
90438449a1
Eltek Enexus; Fix SmartpackS divisor and hardware discovery (#14762) 2022-12-29 22:10:10 +00:00
Nick Peelman
27fbfef2d8
SROS/TIMOS: additional sensors (#14756) 2022-12-24 22:38:36 +00:00
Skylark
02e78aab1d
Fix for RIPE NCC API Tools (#14757) 2022-12-24 22:36:26 +00:00
mrwold
098bbc6bbd
Device - Add support for "Smartpack R" (#14665)
* Update enexus.yaml

Add support for "Smartpack R"

* Update enexus.yaml

* stop adding specific models

Anything responding to the oid should be valid.

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-12-20 07:58:01 -06:00
Tony Murray
1ab238a4d1
Fix port speed setting feedback (#14743) 2022-12-19 18:41:59 -06:00
fcqpl
ae22662c8d
Update Nvidia application - values in wrong charts (#14736) 2022-12-19 09:54:34 +01:00
rhinoau
03482ddd65
Added Moxa switching ifAlias/portName mapping (#14633)
* WIP: Added Moxa switching ifAlias/portName mapping

* style fixes
2022-12-16 09:59:41 -06:00
AdamB
8b2e2f8d95
Prevent spurious MAC changes on multi-interface devices (#14671) 2022-12-16 09:46:10 -06:00
gewuerfelt
f56295c0ea
Update fs-nmu.inc.php (#14702) 2022-12-16 11:41:00 +01:00
Tony Murray
8ea3f5cd06
Offer opt in to usage and error reporting during install (#13906)
and on the about page
2022-12-15 19:52:22 -06:00
Tony Murray
88c86f2a19
Fix graph output base64 (#14701)
Mostly for people using unauth graphs instead of the api.
2022-12-15 15:58:56 -06:00
Tony Murray
1d3440b943
Unify time interval formatting (#14733)
* Unify time interval formatting
Use carbon for formatting, it supports locales.

* fix style

* remove baseline exceptions

* fixes found by lint
2022-12-15 15:52:53 -06:00
Andy Norwood
d091788f28
API list_devices update with sysName, location_id and type (#14731)
* Add sysName, location_id, type to list_devices

* Add new list_devices type
2022-12-15 08:25:11 -06:00
electrocret
f085a5da06
Fix Cimc on Overview (#14727) 2022-12-15 01:49:33 +01:00
AdamB
3a085d89c9
Use 'counter' RRD type for some TrueNAS sensors (#14670)
* Use 'counter' for some TrueNAS sensors

* Test Data

* Missed one

* Update index to force sensor to be re-discovered

* Switch sufix from '_Count' to '_rate'
2022-12-09 17:27:39 +01:00
Gilles Depeyrot
ceb8a02a99
Search devices using display field as well (#14714) 2022-12-09 17:25:42 +01:00
bnerickson
a556aca1d2
Removing max polling restriction for wireguard traffic RRD data (#14710) 2022-12-08 01:41:06 +01:00
Garcia MICHEL
49abee3722
Fix check rrd file exists with remote rrdcached (#14690) 2022-12-01 08:20:49 -06:00
Bogdan-Stefan Rotariu
5dd5e880b7
Update sensor.inc.php, adding $unit to Average (#14680)
Due to a mistake, I forgot to add $unit to Average
2022-11-30 20:36:27 -06:00
Tony Murray
2a8b8b864b
Fix some graphs not respecting device display name (#14684)
Just a quick fix
2022-11-30 07:39:38 -06:00
Bogdan-Stefan Rotariu
eca3b6bf77
Adding Average into graphs (#14679)
This modification adds average description into graphs.
2022-11-28 08:50:52 -06:00
Denny Friebe
54094a4038
Support Huawei SMU02B (#14673)
Signed-off-by: Denny Friebe <nightcore500@users.noreply.github.com>

Signed-off-by: Denny Friebe <nightcore500@users.noreply.github.com>
2022-11-24 17:34:27 +01:00
mabra94
fbfd0a72ee
Bug - Handle Division by 0 error for SvcFdbTable (#14672) 2022-11-23 17:04:56 +01:00
VoipTelCH
e55e49ddf6
Fix discovery ignores custom ipmi port (#14660)
* Update ipmi.inc.php

* Update ipmi.inc.php

Fix use default port if not specified

* Update ipmi.inc.php

Fixed for more consistency with the rest of the file

* filter_var returns the value

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-11-22 09:41:51 -06:00
Tony Murray
41967743f4
Fix neighbours XSS (#14658)
Reported via Huntr.dev by @zluudg
2022-11-19 21:44:14 -06:00
Noah Roufus
9e9720fc17
Added divisor to SAF Integra-X temp sensors (#14655) 2022-11-18 19:48:46 -06:00
Noah Roufus
52f984c78b
Corrected ICT MPS hardware detection (#14654)
* Corrected ICT MPS hardware detection

* Updated test data for ICT MPS
2022-11-18 16:30:45 -06:00
SourceDoctor
df0c41672a
custom port view fix (#14637)
* custom port view fix

* .

* code adjustment

* code adjustment

* .
2022-11-18 16:28:39 -06:00
Tony Murray
752bbc1531
Port search API search more than one fields (#14646)
* Fix port search columns

* Port search API search more than one fields
Fixup port APIs
Change validate_column_list api helper to throw a renderable exception on error and return the valid columns
DeviceCache::get() can handle a bigger range of input

* whitespace

* Refactor exceptions a bit

* change throws type to be more generic

* Lint fixes
2022-11-18 16:27:56 -06:00
SourceDoctor
e851c9abd4
Alarm Flag on UPS-Nut Application (#14635)
* Alarm Flag on UPS-Nut Application

* code adjustemnt
2022-11-18 21:15:21 +01:00
fcqpl
6c3424f149
Added support for Eltek Micropack 1U (#14645)
Added support for Eltek Micropack 1U

```
SNMP['/usr/bin/snmpget' '-M' '/opt/librenms/mibs:/opt/librenms/mibs/eltek' '-v2c' '-c' 'COMMUNITY' '-OQXUte' 'udp:HOSTNAME:161' '.1.3.6.1.4.1.12148.10.2.6.0']  
iso.*.1.12*.0 = "Micropack 1U"
```
2022-11-17 23:29:15 -06:00
electrocret
4c0ebb6f74
Add Columns to search_ports API function (#14348)
* Add Columns to search_ports function

* StyleCI

* StyleCI

* Add to Docs

* Suggested If fix
2022-11-17 10:18:09 -06:00
fcqpl
0670168325
Added support for Eltek Flatpack S (#14643) 2022-11-17 14:14:48 +01:00
Tony Murray
cb9e01a030
Fix device poller modules graph (#14640) 2022-11-16 13:48:30 -06:00
bnerickson
9b41fa3f30
Adding wireguard app to the apps overview page (#14629) 2022-11-13 22:58:00 +01:00
Javier Alejandro Ruiz G
5121f10587
Fix billing graph when the period is zero or doesn't exist, before the fix a divide by zero error was happening when the billing api was being call for an image (#14623) 2022-11-13 13:53:54 +01:00
PipoCanaja
8176e726bc
improvePower (#14624) 2022-11-13 13:53:34 +01:00
bnerickson
bb536bb6fe
Adding wireguard application support (#14625) 2022-11-13 11:07:24 +01:00
Kim Håkonsen
f37def7986
Set 0 as integer in loading of graylog. (#14621)
#14476 probably made this require integer instead of empty string as default.
2022-11-12 15:03:24 -06:00
rhinoau
2f4744c869
Added Moxa EDS-G516E optical sensors (#14610) 2022-11-10 08:55:40 +01:00
ianhodgson
d6630759ff
Edgeos picked up as generic device (#14612)
Edgeos on EdgeRouter Lite 3-Port (erlite-3) picked up as generic device #14611

Not sure about other edgemax devices but the value of sysDescr for the EdgeRouter Lite running v2.0.9-hotfix.4 is "Ubiquiti EdgeOS", so neither regex matches.
2022-11-10 08:31:27 +01:00
Tony Murray
3e6ad9006a
Fix eNexus total current for Smartpack S (#14606)
* Fix eNexus divisor
Thanks to @loopodoopo, it looks like Smartpack S returns 1/10 Amps instead of Amps.
Set them separately

fixes #14414

* I did not wait for data to fully update :D
2022-11-09 11:07:08 -06:00
geg347
96c7e7166e
Adding device's field in get_alert_rule and list-alert-rules API function (new) (#14481)
* Adding device's field in get_alert_rule and lis-alert-rules API function

* Converting SQL request for list/get_alert_rules to Eloquent (thanks a lot to Murrant)

* Manually added #14500 to pass pipeline

* Fixing StyleCI error + trying to fix PHPStan errors

* Trying to fix PHPStan errors (part 2)
2022-11-09 08:21:41 -06:00
Tony Murray
b9d8a7c33c
Improved AIX os information collection (#14595)
* Improved AIX os information collection

* Fix-up merged data

* remove baseline
2022-11-09 12:04:56 +01:00
Jellyfrog
71d740770b
Remove Log::event (#14526)
* Remove Log::event

Use the Eventlog class directly instead

* wip

* wip

* wip

* Apply fixes from StyleCI

* Update Eventlog.php
2022-11-09 09:47:19 +01:00
fufroma
7ca41179bd
Disable SNMP Bulk for Delta UPS devices (#14599)
Some devices like the Delta Electronics Amplon RT-2K need SNMP Bulk to be disable.
2022-11-08 18:22:20 +01:00
Talk Straight Ltd
9826fa9089
feat: Add sortorder parameter to list_logs (#14600) 2022-11-08 18:20:34 +01:00
Tony Murray
94b86e7e7e
More inclusive Cisco SB os detection (#14594) 2022-11-07 14:06:31 -06:00
Zane C. Bowers-Hadley
8511611f64
add HV Monitor, a generic means for monitoring hypvervisors (#14218)
* add HV::Monitor support

* document hv monitor

* add HV Monitor tests

* style cleanup

* fix a few missed style items

* test fix

* more test cleanup

* more minor test tweaks

* more test cleanup

* more test tweaking

* test ordering fix all done... hopefully

* more test cleanup

* minor formatting change
2022-11-07 13:35:48 -06:00
Tony Murray
9d3d81bb11
IP Infusion OcNOS basic detection (#14588)
* IP Infusion OcNOS basic detection

* add test data

* add os data
2022-11-07 13:09:33 -06:00
Tony Murray
0801af7a81
Consolidate and improve snmptranslate usage (#14567)
* Consolidate and improve snmptranslate usage

* Fix style

* lint fixes

* fix typo

* allow multiple mib directories

* Only add mib if it is not already set

* oid first, in case we have key length issues

* if there is a full oid, don't add other mibs

* debug in ci

* more debug in ci

* better debug in ci

* remove debug

* Use numeric index

* revert dlink change

* Don't add -On twice

* unit tests and hopefully better heuristics

* remove dump and add one more set of tests

* style fixes

* handle bad input in old functions

* shortcut whole snmp_translate function
2022-11-07 12:00:47 -06:00
PipoCanaja
70524b1e9d
fix array (#14564) 2022-11-07 07:10:20 -06:00
Tony Murray
9cb6e7b665
Fix port neighbors missing (#14586)
Inverted check when fixing another bug
2022-11-06 17:06:10 -06:00
Bierchermuesli
7f3301caa4
Device - Basic hatteras dslam integration (#14115)
* basic hatteras dslam integration

* snmprec and json test files

* fix HN4000e variant

* add hn4000e variant

* logo and yaml fixes

* change type in test file

* inexistent(?) disco module removed: route

* Update hatteras.yaml

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-11-05 14:43:23 -05:00
Jellyfrog
009d69a48d
Use Collection instead of collect() (#14527)
* Use Collection instead of collect()

* wip
2022-11-05 10:04:36 +01:00
Tony Murray
78d6ed49ee
Fix some icons (#14584)
fa-info icons, update to FA6 style
2022-11-04 23:13:36 -05:00
Tony Murray
6cbe6fde4f
Mock astext (#14581)
* Mock astext
avoid dns failures

* whitespace

* fix arista

* restore test data except astext

* restore test data except astext

* Full fresh run

* Move DI call into class
2022-11-05 01:18:52 +01:00
Tony Murray
126696e26b
Fix APC current divide by zero (#14578) 2022-11-04 11:18:29 -05:00
mprins-RAM
bca7591084
Added Fortigate SD-WAN Health checks (#14456)
* Added Fortigate SD-WAN Health checks

* Add unit test

* Fix for displaying user description when F2A isnt used

* Revert "Fix for displaying user description when F2A isnt used"
This reverts commit d9f170d7e6.

* Fix for displaying user description when F2A isnt used

* Fixing comments

* Requested changes, with modified tests

* adding the correct tests

* fix tests

* fix tests

* Testing issue resolved

* fixing tests
2022-11-04 10:41:06 -05:00
Tony Murray
539ef9ff90
Fix graph errors wrong content type (#14574)
Some code was returning too soon and messing up the return type
Other code was simply not setting it
2022-11-03 15:07:17 -05:00
Tony Murray
95e81a53a8
Fix device bits overview when no ports are included (#14573) 2022-11-03 13:29:17 -05:00
Tony Murray
2fb81ce429
Fix graph previous period getting partially applied (#14572) 2022-11-03 12:33:29 -05:00
Tony Murray
511e345321
API graphs, variable whitelist (#14552)
* API graphs, variable whitelist
Restore several missing parameters that relied on graphing code fetching from $_GET directly.
Whitelist valid parameters to set on the request get
Move common parameter handling into common code

* Fix style

* Include previous
2022-11-03 01:08:52 -05:00
PipoCanaja
bd4c2d70fb
McAfee Web Proxy with COUNTER rrd_type on sensors (#14529)
* webGw1

* rrd_type for mcafeewebgateway.yaml

* update tests
2022-11-02 18:45:52 -05:00
PipoCanaja
ce6eaadc2a
More Replacement Capabilities for sensor index computation (#14522)
* More Replacement Cap.

style

* more compact

* fix mni.yaml

* too compact, revert

* quantastor

* str_replace was never matched
2022-11-02 16:54:40 -05:00
squidly
de9787ea9a
Added support for Vultan Environmental Monitoring units (#14401)
* adding new os: vutlan

* renaming mib file, moving mib file to vendor folder, removing commented code

* Cache version data (#14404)

* Cache version data
Calling cli commands can be expensive, cache the results.

* style fixes

* Fix pre-laravel usage

* fix lint

* Revert "Cache version data (#14404)"

This reverts commit e426a9299d.

* fixing descr for door state and removing comments

* adding tests and moving vutlan definition file

* adding num_oid value for tests

* Rename VUTLAN-SYSTEM-MIB.mib to VUTLAN-SYSTEM-MIB

* Update vutlan_vt825.json

* updating test data

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-11-02 19:31:12 +01:00
Tony Murray
2dea36f70f
Remove graph_min (#14561)
* Remove graph_min
it doesn't do anything
(scale_min sets minimum graph scale)
(graph_max shows a line at max on some graphs)

* fix style
2022-11-02 09:55:28 -05:00
Tony Murray
95a0050074
Remove $_GET from graphs (#14554)
Fixes issues setting variables in other contexts
2022-11-02 08:24:42 -05:00
PipoCanaja
624ebf8d55
Extend EfficientIP SolidServer support (#14549) 2022-11-02 08:24:39 +01:00
bnerickson
a63b12a00d
XSS sanitize pwrstatd application script inputs (#14545)
* XSS sanitize pwrstatd application script inputs

* Removing is_int logic
2022-11-01 20:33:17 -05:00
SirMaple
5a69ac687d
Add check_hetzner_storagebox to includes/services (#14463)
When using check_hetzner_storagebox (https://github.com/muensmedia/check_hetzner_storagebox) the -H can not be passed.
2022-11-02 00:59:59 +01:00
Tony Murray
07cc9f4cdc
Fix XSS in api access (#14551)
api access page didn't escape username allowing for injection.
2022-11-01 11:20:08 +01:00
Tony Murray
7d9f22705f
Memcached application improve error visibility (#14536) 2022-10-31 08:13:41 -05:00
bnerickson
d28b1cac3f
Adding systemd application (#14540) 2022-10-30 14:18:02 -05:00
O Palivan
437322f8cb
TAIT-Infra93 - Fix state + skip_values for Battery (#14541) 2022-10-30 11:13:41 +01:00
Tony Murray
4b65dc41d2
Graphing cleanup (#14492)
* WIP

* Fixes and cleanups

* Move parseAtTime to Time util class

* lint fixes, explicitly define variables

* Style fixes
2022-10-28 08:06:29 -05:00
Jellyfrog
d5fcf53e01
Correct variable use in billing (#14533) 2022-10-28 12:55:37 +02:00
Jellyfrog
b90fbcb9bf
Undefined array key fixes (#14532)
* Undefined array key fixes

* Update check-services.php
2022-10-27 21:02:27 +02:00
Tony Murray
0dd183f1e1
fix awplus ntp polling bug (#14521)
tries to count an integer :/
2022-10-26 20:47:46 +02:00
PipoCanaja
0470b03456
fix bke yaml file (#14524) 2022-10-26 19:05:07 +02:00
rhinoau
7436ef4425
Added support for additional Moxa EDS-P model (#14523) 2022-10-26 10:44:08 +02:00
O Palivan
c2678c1b6c
EES Rectifier various fixes from MIB + added tests (#14519)
* EES fixes from MIB + added tests
* Another typo
* Another typo + Tests
* Update ees_v2-2-12.json

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2022-10-25 23:01:05 +02:00
Jellyfrog
b6620746c5
Miscellaneous cleanup - part 5 (#14502)
* Miscellaneous cleanup - part 5

* Update includes/discovery/sensors/pre-cache/ipoman.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>

* Update ipoman.inc.php

* string for trim()

* Update ciscosb.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-10-25 19:27:28 +02:00
SourceDoctor
505abd7136
Sort alert transport by name (#14464)
* sort alert transport by name

* .

* .

* code update

* code update
2022-10-25 08:43:54 -05:00
PipoCanaja
8e3fe223ef
Sensors - Allow changing RRD type in YAML and PHP sensor discovery (#14208)
* new row variant

* syntax

* syntax

* DB

* syntax

* schema

* test

* allAdvaTests

* Tests

* Tests

* Tests

* missingMigration

* missingMigration

* Tests

* Tests

* Tests

* Tests

* tests

* tests

* tests

* tests

* tests

* test

* fix_Aos7

* fix snmprec arista

* fix snmprec arista

* fix snmprec arista

* tests

* merge_fix

* aos7 backslash

* aos7

* more

* more

* defaultValue

* arista

* typehint

* tests

* tests

* voss

* aos7

* aos7

* aos7

* testWithoutarista-mos_metamux48-c-0-16.json

* tests

* ciscosb

* new tests with 2004 and only sensors module

* adding wireless module again

* adding wireless module again (cont)

* airos

* aos7

* arista

* arista

* bdcom

* fortigate

* fortigate

* fortigate

* ftos

* ftos

* tests on 1804

* tests once more

* tests once more, cont

* tests once more, cont

* tests once more, cont

* tests once more, cont

* tests once more, cont

* more

* bdcom

* comware

* edgeosolt

* enexus

* arista-mos

* removeAristaAgain

* ies500_manual_edit

* ies500_manual_edit

* mni

* volius

* zywal

* manually imported arista-mos

* manually imported arista-mos

* arista-mos test is triggering something ...

* restoreArista

* tests

* tests

* aristamos

* ies52xxM_4206.json

* revert linux_supermicro.json

* revert linux_supermicro.json

* benuos

* fortiadc

* rnx-updu
2022-10-25 08:31:02 -05:00
Tony Murray
797e18e943
Fix memcached polling bug (#14501) 2022-10-24 21:25:25 -05:00
Mark Westerterp
db4dce298a
Fortinet FortiADC detection and basic statistics (#14434)
* FortiADC detection and basic statistics

* Style fix

* Fixed test data

* Fix test data

* Recollected all test data

* Add num_oid
2022-10-24 18:28:47 +02:00
Lucas Gasenzer
707f2cd29f
Check if service_name is empty or equal to service_type (#14499)
* Check if name empty or name == service

* Linting ("" → '')
2022-10-23 20:00:29 +02:00
André Keller
056dbc9a57
Add discovery support for Riedo Networks UPDU (#14496)
* Add discovery support for Riedo Networks UPDU

* Add full test data

* Use correct filename for MIB

* Extract hardware, serial and firmware version

* Make pattern more consistent

* Fix incomplete test data
2022-10-23 00:24:31 +02:00
rhinoau
6372041d39
Fix update_device hostname handling #14435 (#14448)
* Fix device_update hostname handling #14435

* Use Eloquent

* Update Device.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-10-22 15:45:47 -05:00
Tony Murray
aefd14d3aa
Graph API use new code path (#14493)
* Graph API use new code path
Improves error handling significantly

* Actually base64 encode it
2022-10-22 14:58:51 -05:00
SourceDoctor
04f0574132
show id on device dependencies (#14497) 2022-10-22 19:52:51 +02:00
Jellyfrog
9422b34294
RFC1628: Correct upsBypassVoltage oid (#14488)
* RFC1628: Correct upsBypassVoltage oid

* Update istars.json
2022-10-22 11:46:51 +02:00
Jellyfrog
19cff69c28
Liebert: use correct description oid (#14489)
* Update liebert.json

* Update liebert.inc.php
2022-10-22 11:46:34 +02:00
Zane C. Bowers-Hadley
a166df006a
base64 gzip compression support for json_app_get (#14169)
* add lnms_return_optimizer

* add compression test using zfs-v1

* minor style fix

* save the original output if not json

* replace gzinflate with gzdecode as apparently that does not require yanking the header

* Minor comment cleanup. Also note it in the application notes as well.

* update docs on how it is called

* update the spelling of it in a few places

* and a few more

* dev docs updated a bit

* the suricata extend has native support for this now

* add exception handling for base64 and gzip decoding failure

* minor cleanup for new exceptions

* minor misc changes

* minor formatting fix

* more phpdoc tweaks

* minor formatting tweak

* remember to actually include the new exceptions

* more phpdoc tweaking

* correct name in JsonAppGzipDecodeException

* add debug and verbose output

* style fix

* not base64 is it starts with a line with only a integer
2022-10-21 10:05:49 -05:00
Jellyfrog
0f13b37b4c
Fix fetch ifEntry logic (#14483)
* Fix fetch ifEntry logic

* Update includes/polling/ports.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-10-21 07:28:41 -05:00
Jellyfrog
3848941d55
hpe ilo: fix filesystem type regex (#14485)
* Update hpe-ilo.inc.php

* Update hpe-ilo_4_with_bat_checks.json

* Update hpe-ilo_5_with_bat_checks.json
2022-10-20 22:50:00 +02:00
Jellyfrog
56d0c7af19
intelliflash: correct variable typo (#14486)
* intelliflash: correct variable typo

* Update intelliflash.json
2022-10-20 22:49:46 +02:00
Jellyfrog
b18ba17af0
Miscellaneous cleanup - part 4 (#14452)
* Miscellaneous cleanup - part 4

* wip

* wip
2022-10-19 01:33:06 +02:00