newdevice: Added detection and sensor support for EMC OneFS v8 (#6416)

* newdevice: Added detection and sensor support for EMC OneFS v8

* Improve discovery

includes/definitions/onefs.yaml

@@ -2,6 +2,8 @@ os: onefs
 text: 'EMC Isilon OneFS'
 type: storage
 icon: emc
+mib_dir:
+    - emc
 over:
     - { graph: device_bits, text: 'Device Traffic' }
     - { graph: device_processor, text: 'CPU Usage' }
@@ -10,3 +12,5 @@ over:
 discovery:
     - sysObjectId:
         - .1.3.6.1.4.1.12124.1
+    - sysDescr:
+        - 'Isilon OneFS'

includes/discovery/sensors/fanspeed/onefs.inc.php

@@ -0,0 +1,38 @@
+<?php
+/**
+ * onefs.inc.php
+ *
+ * LibreNMS fanspeeds module for OneFS
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * @package    LibreNMS
+ * @link       http://librenms.org
+ * @copyright  2017 Neil Lathwood
+ * @author     Neil Lathwood <gh+n@laf.io>
+ */
+
+echo 'OneFS: ';
+$oids = snmpwalk_cache_multi_oid($device, 'fanTable', array(), 'ISILON-MIB');
+
+foreach ($oids as $index => $entry) {
+    if (is_numeric($entry['fanSpeed']) && is_numeric($index)) {
+        $descr   = $entry['fanDescription'];
+        $oid     = '.1.3.6.1.4.1.12124.2.53.1.4.'.$index;
+        $current = $entry['fanSpeed'];
+        discover_sensor($valid['sensor'], 'fanspeed', $device, $oid, $index, 'onefs', $descr, '1', '1', 0, 0, 5000, 9000, $current);
+    }
+}
+
+unset($oids);

includes/discovery/sensors/temperature/onefs.inc.php

@@ -0,0 +1,38 @@
+<?php
+/**
+ * onefs.inc.php
+ *
+ * LibreNMS temperature module for OneFS
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * @package    LibreNMS
+ * @link       http://librenms.org
+ * @copyright  2017 Neil Lathwood
+ * @author     Neil Lathwood <gh+n@laf.io>
+ */
+
+echo 'OneFS: ';
+$oids = snmpwalk_cache_multi_oid($device, 'tempSensorTable', array(), 'ISILON-MIB');
+
+foreach ($oids as $index => $entry) {
+    if (is_numeric($entry['tempSensorValue']) && is_numeric($index)) {
+        $descr   = $entry['tempSensorDescription'];
+        $oid     = '.1.3.6.1.4.1.12124.2.54.1.4.'.$index;
+        $current = $entry['tempSensorValue'];
+        discover_sensor($valid['sensor'], 'temperature', $device, $oid, $index, 'onefs', $descr, '1', '1', null, null, null, null, $current);
+    }
+}
+
+unset($oids);

includes/discovery/sensors/voltage/onefs.inc.php

@@ -0,0 +1,38 @@
+<?php
+/**
+ * onefs.inc.php
+ *
+ * LibreNMS power module for OneFS
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * @package    LibreNMS
+ * @link       http://librenms.org
+ * @copyright  2017 Neil Lathwood
+ * @author     Neil Lathwood <gh+n@laf.io>
+ */
+
+echo 'OneFS: ';
+$oids = snmpwalk_cache_multi_oid($device, 'powerSensorTable', array(), 'ISILON-MIB');
+
+foreach ($oids as $index => $entry) {
+    if (is_numeric($entry['powerSensorValue']) && is_numeric($index)) {
+        $descr   = $entry['powerSensorDescription'];
+        $oid     = '.1.3.6.1.4.1.12124.2.55.1.4.'.$index;
+        $current = $entry['powerSensorValue'];
+        discover_sensor($valid['sensor'], 'voltage', $device, $oid, $index, 'onefs', $descr, '1', '1', null, null, null, null, $current);
+    }
+}
+
+unset($oids);

includes/discovery/storage/onefs.inc.php

@@ -0,0 +1,40 @@
+<?php
+/**
+ * onefs.inc.php
+ *
+ * LibreNMS storage module for OneFS
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * @package    LibreNMS
+ * @link       http://librenms.org
+ * @copyright  2017 Neil Lathwood
+ * @author     Neil Lathwood <gh+n@laf.io>
+ */
+
+if ($device['os'] === 'onefs') {
+    $oids = snmp_get_multi_oid($device, 'ifsTotalBytes.0 ifsUsedBytes.0 ifsAvailableBytes.0', '-OUQn', 'ISILON-MIB');
+
+    $fstype = "ifs";
+    $descr  = "Internal File System";
+    $units  = 1024;
+    $index  = 0;
+    $free   = $oids['.1.3.6.1.4.1.12124.1.3.3.0'];
+    $total  = $oids['.1.3.6.1.4.1.12124.1.3.1.0'];
+    $used   = $oids['.1.3.6.1.4.1.12124.1.3.2.0'];
+    if (is_numeric($free) && is_numeric($total)) {
+        discover_storage($valid_storage, $device, $index, $fstype, 'onefs', $descr, $total, $units, $used);
+    }
+    unset($oids);
+}

includes/polling/storage/onefs.inc.php

@@ -0,0 +1,31 @@
+<?php
+/**
+ * onefs.inc.php
+ *
+ * LibreNMS storage module for OneFS
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * @package    LibreNMS
+ * @link       http://librenms.org
+ * @copyright  2017 Neil Lathwood
+ * @author     Neil Lathwood <gh+n@laf.io>
+ */
+
+$onefs_oids = snmp_get_multi_oid($device, 'ifsTotalBytes.0 ifsUsedBytes.0 ifsAvailableBytes.0', '-OUQn', 'ISILON-MIB');
+$storage['free']   = $onefs_oids['.1.3.6.1.4.1.12124.1.3.3.0'];
+$storage['size']  = $onefs_oids['.1.3.6.1.4.1.12124.1.3.1.0'];
+$storage['used']   = $onefs_oids['.1.3.6.1.4.1.12124.1.3.2.0'];
+$storage['units']  = 1024;
+unset($onefs_oids);

tests/OSDiscoveryTest.php

@@ -1283,6 +1283,7 @@ class DiscoveryTest extends \PHPUnit_Framework_TestCase
     public function testOnefs()
     {
         $this->checkOS('onefs');
+        $this->checkOS('onefs', 'onefs-v8');
     }
 
     public function testOns()

tests/snmpsim/onefs-v8.snmprec

@@ -0,0 +1,2 @@
+1.3.6.1.2.1.1.1.0|4|NC-EMC-CLUSTER-1-1 4280738515 Isilon OneFS v8.0.1.1
+1.3.6.1.2.1.1.2.0|6|1.3.6.1.4.1.12325.1.1.2.1.1