From 7e96d8702212765b3a62717f92186172c63d3ffe Mon Sep 17 00:00:00 2001
From: Tom Laermans <tom@localhost>
Date: Sun, 6 May 2012 23:02:18 +0000
Subject: [PATCH] improvements to services

git-svn-id: http://www.observium.org/svn/observer/trunk@3144 61d68cd4-352d-0410-923a-c4978735b2b8
---
 check-services.php                  |  2 --
 html/includes/service-add.inc.php   | 12 ------------
 html/pages/addsrv.inc.php           | 11 ++++++++++-
 includes/common.php                 |  8 ++++++++
 includes/discovery/services.inc.php |  2 +-
 includes/services.inc.php           | 17 ++++++++---------
 6 files changed, 27 insertions(+), 25 deletions(-)
 delete mode 100644 html/includes/service-add.inc.php

diff --git a/check-services.php b/check-services.php
index fcbc47df11..d3ce5fa961 100755
--- a/check-services.php
+++ b/check-services.php
@@ -3,8 +3,6 @@
 
 chdir(dirname($argv[0]));
 
-$debug=1;
-
 include("includes/defaults.inc.php");
 include("config.php");
 include("includes/functions.php");
diff --git a/html/includes/service-add.inc.php b/html/includes/service-add.inc.php
deleted file mode 100644
index bf15839b40..0000000000
--- a/html/includes/service-add.inc.php
+++ /dev/null
@@ -1,12 +0,0 @@
-<?php
-
-  $updated = '1';
-
-  $service_id = dbInsert(array('device_id' => $_POST['device'], 'service_ip' => $_POST['ip'], 'service_type' => $_POST['type'], 'service_desc' => $_POST['descr'], 'service_param' => $_POST['params'], 'service_ignore' => '0'), 'services');
-
-  if ($service_id) {
-    $message .= $message_break . "Service added (".$service_id.")!";
-    $message_break .= "<br />";
-  }
-
-?>
diff --git a/html/pages/addsrv.inc.php b/html/pages/addsrv.inc.php
index f6ccaf69d5..644f5ff29f 100644
--- a/html/pages/addsrv.inc.php
+++ b/html/pages/addsrv.inc.php
@@ -10,7 +10,16 @@ else
   {
     if ($_SESSION['userlevel'] == '10')
     {
-      include("includes/service-add.inc.php");
+      $updated = '1';
+
+      #FIXME should call add_service (needs more parameters)
+      $service_id = dbInsert(array('device_id' => $_POST['device'], 'service_ip' => $_POST['ip'], 'service_type' => $_POST['type'], 'service_desc' => $_POST['descr'], 'service_param' => $_POST['params'], 'service_ignore' => '0'), 'services');
+
+      if ($service_id)
+      {
+        $message .= $message_break . "Service added (".$service_id.")!";
+        $message_break .= "<br />";
+      }
     }
   }
 
diff --git a/includes/common.php b/includes/common.php
index 492cf09a29..acb5895f81 100644
--- a/includes/common.php
+++ b/includes/common.php
@@ -525,4 +525,12 @@ function is_valid_hostname($hostname)
   return ctype_alnum(str_replace('_','',str_replace('-','',str_replace('.','',$hostname))));
 }
 
+function add_service($device, $service, $descr)
+{
+  $insert = array('device_id' => $device['device_id'], 'service_ip' => $device['hostname'], 'service_type' => $service,
+                  'service_changed' => array('UNIX_TIMESTAMP(NOW())'), 'service_desc' => $descr, 'service_param' => "", 'service_ignore' => "0");
+
+  echo dbInsert($insert, 'services');
+}
+
 ?>
diff --git a/includes/discovery/services.inc.php b/includes/discovery/services.inc.php
index 0c17480700..719a765c5b 100644
--- a/includes/discovery/services.inc.php
+++ b/includes/discovery/services.inc.php
@@ -24,7 +24,7 @@ if ($config['discover_services'])
           $tcp_port = $split_oid[count($split_oid)-6];
           if ($known_services[$tcp_port])
           {
-            add_service($device,$known_services[$tcp_port]);
+            discover_service($device,$known_services[$tcp_port]);
           }
         }
       }
diff --git a/includes/services.inc.php b/includes/services.inc.php
index daadf028e5..eeacaa8707 100644
--- a/includes/services.inc.php
+++ b/includes/services.inc.php
@@ -1,16 +1,15 @@
 <?php
 
-## FIXME who wrote this? so ugly :)
-# Not me! -TL
-
-function add_service($device, $service)
+function discover_service($device, $service)
 {
+  if (! dbFetchCell("SELECT COUNT(service_id) FROM `services` WHERE `service_type`= ? AND `device_id` = ?", array($service, $device['device_id'])))
+  {
+    add_service($device, $service, "(Auto discovered) $service");
+    log_event("Autodiscovered service: type " . mres($service), $device, 'service');
+    echo("+");
+  }
+
   echo("$service ");
-
-  $insert = array('device_id' => $device['device_id'], 'service_ip' => $device['hostname'], 'service_type' => $service,
-                  'service_desc' => "auto discovered: $service", 'service_param' => "", 'service_ignore' => "0");
-
-  return dbInsert($insert, 'services');
 }
 
 ?>