From 58ccccce294db6ee1e43d1d6aeffbee0464886e1 Mon Sep 17 00:00:00 2001 From: Jellyfrog Date: Mon, 2 Sep 2024 16:36:41 +0200 Subject: [PATCH] use the already installed chromedriver (#16341) --- .github/workflows/test.yml | 4 ++-- tests/DuskTestCase.php | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index fdf4f074d2..8c14dba1bb 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -133,10 +133,10 @@ jobs: run: | php lnms dev:simulate --setup-venv - - name: Artisan dusk:chrome-driver + name: Start ChromeDriver if: matrix.skip-web-check != '1' run: | - php artisan dusk:chrome-driver --detect + $CHROMEWEBDRIVER/chromedriver --port=9515 & - name: Copy seeded config run: cp "${GITHUB_WORKSPACE}/tests/testing_config.yaml" "${GITHUB_WORKSPACE}/database/seeders/config/" diff --git a/tests/DuskTestCase.php b/tests/DuskTestCase.php index 94496da0ee..a8255e547f 100644 --- a/tests/DuskTestCase.php +++ b/tests/DuskTestCase.php @@ -20,7 +20,7 @@ abstract class DuskTestCase extends BaseTestCase */ public static function prepare() { - if (! static::runningInSail()) { + if (! static::runningInSail() && ! getenv('GITHUB_ACTIONS')) { static::startChromeDriver(); } }