clones/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2024-09-21 10:37:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(mobile) timeline slider no longer dissapears (#9358)

Browse Source 
fix(mobile) added heightOffset, scrollbar accounts for main appBar and does not get squished

Co-authored-by: Alex <alex.tran1502@gmail.com>
This commit is contained in:
Conner Hnatiuk 2024-05-09 11:31:25 -06:00 committed by GitHub
parent 55031cc117
commit 34d8879d32
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mobile/lib/widgets/asset_grid/draggable_scrollbar_custom.dart
View File

@ -36,6 +36,9 @@ class DraggableScrollbar extends StatefulWidget {
/// The amount of padding that should surround the thumb /// The amount of padding that should surround the thumb
final EdgeInsetsGeometry? padding; final EdgeInsetsGeometry? padding;
/// The height offset of the thumb/bar from the bottom of the page
final double? heightOffset;
/// Determines how quickly the scrollbar will animate in and out /// Determines how quickly the scrollbar will animate in and out
final Duration scrollbarAnimationDuration; final Duration scrollbarAnimationDuration;
@ -67,6 +70,7 @@ class DraggableScrollbar extends StatefulWidget {
this.heightScrollThumb = 48.0, this.heightScrollThumb = 48.0,
this.backgroundColor = Colors.white, this.backgroundColor = Colors.white,
this.padding, this.padding,
this.heightOffset,
this.scrollbarAnimationDuration = const Duration(milliseconds: 300), this.scrollbarAnimationDuration = const Duration(milliseconds: 300),
this.scrollbarTimeToFade = const Duration(milliseconds: 600), this.scrollbarTimeToFade = const Duration(milliseconds: 600),
this.labelTextBuilder, this.labelTextBuilder,
@ -247,7 +251,9 @@ class DraggableScrollbarState extends State<DraggableScrollbar>
} }
double get barMaxScrollExtent => double get barMaxScrollExtent =>
(context.size?.height ?? 0) - widget.heightScrollThumb; (context.size?.height ?? 0) -
widget.heightScrollThumb -
(widget.heightOffset ?? 0);
double get barMinScrollExtent => 0; double get barMinScrollExtent => 0;

1
mobile/lib/widgets/asset_grid/immich_asset_grid_view.dart
View File

@ -267,6 +267,7 @@ class ImmichAssetGridViewState extends ConsumerState<ImmichAssetGridView> {
padding: appBarOffset() padding: appBarOffset()
? const EdgeInsets.only(top: 60) ? const EdgeInsets.only(top: 60)
: const EdgeInsets.only(), : const EdgeInsets.only(),
heightOffset: appBarOffset() ? 60 : 0,
labelConstraints: const BoxConstraints(maxHeight: 28), labelConstraints: const BoxConstraints(maxHeight: 28),
scrollbarAnimationDuration: const Duration(milliseconds: 300), scrollbarAnimationDuration: const Duration(milliseconds: 300),
scrollbarTimeToFade: const Duration(milliseconds: 1000), scrollbarTimeToFade: const Duration(milliseconds: 1000),