mirror of
https://github.com/golang/go.git
synced 2024-09-22 10:58:58 +00:00
cc90e7a51e
The compiler currently has two modes for compilation: one where it compiles each function as it sees them, and another where it enqueues them all into a work queue. A subsequent CL is going to reorder function compilation to ensure that functions are always compiled before any non-trivial function literals they enclose, and this will be easier if we always use the compile work queue. Also, fewer compilation modes makes things simpler to reason about. Change-Id: Ie090e81f7476c49486296f2b90911fa0a466a5dd Reviewed-on: https://go-review.googlesource.com/c/go/+/283313 Run-TryBot: Matthew Dempsky <mdempsky@google.com> TryBot-Result: Go Bot <gobot@golang.org> Trust: Matthew Dempsky <mdempsky@google.com> Reviewed-by: Keith Randall <khr@golang.org>
25 lines
690 B
Go
25 lines
690 B
Go
// errorcheck -0 -live -l
|
|
|
|
// Copyright 2017 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
// Issue 20250: liveness differed with concurrent compilation
|
|
// due to propagation of addrtaken to outer variables for
|
|
// closure variables.
|
|
|
|
package p
|
|
|
|
type T struct {
|
|
s [2]string
|
|
}
|
|
|
|
func f(a T) { // ERROR "live at entry to f: a"
|
|
var e interface{} // ERROR "stack object e interface \{\}$"
|
|
func() { // ERROR "live at entry to f.func1: a &e"
|
|
e = a.s // ERROR "live at call to convT2E: &e" "stack object a T$"
|
|
}()
|
|
// Before the fix, both a and e were live at the previous line.
|
|
_ = e
|
|
}
|