mirror of
https://github.com/golang/go.git
synced 2024-09-22 19:08:30 +00:00
1683dab725
In external link mode the linker explicitly adds the string constant "runtime/cgo". It adds the string constant using the same symbol name as the compiler, but a different format. The compiler assumes that the string data immediately follows the string header, but the linker puts the two in different sections. The result is bad string data when the compiler sees "runtime/cgo" used as a string constant. The compiler assumption is in datastring in [568]g/gobj.c. The linker layout is in addstrdata in ld/data.c. The compiler assumption is valid for string literals. The linker is not creating a string literal, so its assumption is also valid. There are a few ways to avoid this problem. This patch fixes it by only doing the fake import of runtime/cgo if necessary, and by only creating the string symbol if necessary. Fixes #7234. LGTM=dvyukov R=golang-codereviews, dvyukov, bradfitz CC=golang-codereviews https://golang.org/cl/58410043 |
||
|---|---|---|
| .. | ||
| arm | ||
| bash | ||
| bbedit | ||
| cgo | ||
| chrome/gophertool | ||
| dashboard/codereview | ||
| emacs | ||
| fraise | ||
| git | ||
| goplay | ||
| IntelliJIDEA | ||
| kate | ||
| linkcheck | ||
| makerelease | ||
| notepadplus | ||
| swig | ||
| vim | ||
| xcode | ||
| zsh | ||
| benchcmp | ||
| pprof | ||