clones/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2024-09-22 10:58:58 +00:00
Code Issues Packages Projects Releases Wiki Activity
17,296 Commits 59 Branches 428 Tags 641 MiB
fbf5fd5f1e
Commit Graph

37 Commits

Author SHA1 Message Date
Brad Fitzpatrick
3b7dcf074f codereview: close the head tag 
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/9695045
 2013-05-23 14:13:39 -07:00
Brad Fitzpatrick
09395daf2e codereview: add khr as a person 
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/9459046
 2013-05-21 09:02:30 -07:00
Rob Pike
9e643ac20e misc/dashboard/codereview: add cshapiro and mpvl to reviewers list. 
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/9104052
 2013-05-15 10:25:02 -07:00
Dave Cheney
5851b974a3 misc/dashboard/codereview: add Rémy to the list of assignees 
R=dsymonds, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/8094047
 2013-03-30 15:53:44 +11:00
David Symonds
247bc72131 misc/dashboard/codereview: better debugging when some fetches fail. 
R=rsc
CC=golang-dev
https://golang.org/cl/7836045
 2013-03-15 14:45:00 +11:00
David Symonds
b7f29e259d misc/dashboard/codereview: add more people. 
I picked everyone who has committed a CL on behalf of someone else in recent times.

R=r, rsc
CC=golang-dev
https://golang.org/cl/7836044
 2013-03-15 14:33:00 +11:00
Andrew Gerrand
f31f9a61c5 misc/dashboard/codereview: add campoy to list of gophers 
R=dsymonds
CC=golang-dev
https://golang.org/cl/7106044
 2013-01-14 09:54:56 +11:00
Robert Griesemer
465b9c35e5 gofmt: apply gofmt -w src misc 
Remove trailing whitespace in comments.
No other changes.

R=r
CC=golang-dev
https://golang.org/cl/6815053
 2012-10-30 13:38:01 -07:00
David Symonds
b506c3e17a misc/dashboard/codereview: only accept "NOT LGTM" on the first line of a message. 
Too many people quote entire emails and put their reply at the top ("top posting"),
so we shouldn't recognise review commands anywhere in the review text.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6815048
 2012-10-29 22:03:58 +11:00
David Symonds
e803e1cfa6 misc/dashboard/codereview: fixes for non-reviewers. 
Also rename the testing CGI argument from "email" to "user".

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6454117
 2012-08-08 13:16:21 +10:00
Russ Cox
bacccefa8d misc/dashboard/codereview: fix obo 
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6443091
 2012-08-08 11:04:57 +10:00
Russ Cox
ab058b3540 misc/dashboard/codereview: show first line of last message in thread 
This line helps me to tell whether the CL is waiting for me or I'm waiting for the author.

Also:
 - vertical-align table cells so buttons are always aligned with CL headers.
 - add email= to show front page for someone else.

 Demo at http://rsc.gocodereview.appspot.com/.
 Until this is deployed for real, some recently changed CLs may be
 missing the 'first line of last message' part.

R=dsymonds
CC=golang-dev
https://golang.org/cl/6446065
 2012-08-05 14:35:35 -04:00
Russ Cox
09f1f5d76d misc/dashboard/codereview: add LastUpdate field to CL 
To be filled in by a later CL. I deployed a test version to
App Engine to work on setting the values, so there are
a few records that have this field set already.

That field is breaking the live version, so I have pushed
a new copy with this 1-line change to the live version

I assumed that appengine/datastore was like every other
marshaling and unmarshaling package we have in Go
(for example, encoding/gob, encoding/json, encoding/xml,
and protobuf) and that if it loaded an unknown field it would
just ignore it. Apparently not. Sorry.

R=dsymonds
TBR=dsymonds
CC=golang-dev
https://golang.org/cl/6454064
 2012-07-30 10:13:54 -04:00
David Symonds
2a9478ed64 misc/dashboard/codereview: pass user information to gobot when assigning reviewer. 
R=bradfitz
CC=gobot, golang-dev, rsc
https://golang.org/cl/6457052
 2012-07-30 14:41:04 +10:00
David Symonds
e53351013d misc/dashboard/codereview: switch to using gobot to update CL reviewer info. 
R=rsc
CC=golang-dev
https://golang.org/cl/6453063
 2012-07-30 14:13:12 +10:00
David Symonds
4168804639 misc/dashboard/codereview: bump user-specific table limits to 100. 
R=rsc
CC=golang-dev
https://golang.org/cl/6457051
 2012-07-30 14:11:51 +10:00
David Symonds
482ceeda6d misc/dashboard/codereview: interpret zero reviewers as the CL being closed. 
This is the state when the CL has been submitted by someone other than
the CL author, but before the CL author has synched their client.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6458044
 2012-07-30 13:51:21 +10:00
David Symonds
be629bf79e misc/dashboard/codereview: make all active CL tables hold up to 50 CLs. 
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6449060
 2012-07-30 11:45:17 +10:00
David Symonds
3fe5f3353f misc/dashboard/codereview: fix tag nesting. 
R=golang-dev, rsc, minux.ma
CC=golang-dev
https://golang.org/cl/6454062
 2012-07-30 11:37:20 +10:00
David Symonds
3cc9d16792 misc/dashboard/codereview: recognize "NOT LGTM". 
A "NOT LGTM" overrules a previous "LGTM" by the same person, and vice versa.
"NOT LGTM"s are shown in the same location as LGTMs, colored red.

R=rsc
CC=golang-dev
https://golang.org/cl/6453062
 2012-07-30 10:54:50 +10:00
David Symonds
a8ce9ab46c misc/dashboard/codereview: add admin-only link to force-update a CL. 
R=nigeltao
CC=golang-dev
https://golang.org/cl/6431055
 2012-07-23 12:41:23 +10:00
David Symonds
935d8d16d4 misc/dashboard/codereview: handle abandoned CLs. 
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6257082
 2012-06-01 10:55:55 +10:00
David Symonds
a90cbd741a misc/dashboard/codereview: add sameer. 
R=r
CC=golang-dev
https://golang.org/cl/6203076
 2012-05-15 08:38:05 +10:00
David Symonds
58bcec62c0 misc/dashboard/codereview: set In-Reply-To header to properly thread mail. 
R=adg
CC=golang-dev
https://golang.org/cl/6208051
 2012-05-14 10:05:39 +10:00
David Symonds
c44a22cc49 misc/dashboard/codereview: remove transitional code. 
All current CLs have subject lines, so we don't need to check any more.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6196044
 2012-05-04 16:40:24 +10:00
Andrew Gerrand
7a77645aa8 misc/dashboard/codereview: add copyright notices to Go files 
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6177043
 2012-05-03 09:22:45 +10:00
Rob Pike
ce30769ce3 misc/dashboard/codereview: LGTM favicon 
R=dsymonds
CC=golang-dev
https://golang.org/cl/6158043
 2012-05-02 13:48:49 +10:00
David Symonds
cc9a5c3be7 misc/dashboard/codereview: preserve CL ordering. 
R=r
CC=golang-dev
https://golang.org/cl/6136056
 2012-05-01 16:15:32 +10:00
David Symonds
83aa040c45 misc/dashboard/codereview: de-dup LGTMs. 
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6127066
 2012-05-01 11:41:32 +10:00
David Symonds
dae2992c98 misc/dashboard/codereview: send mail immediately, and fill in time.Time fields. 
If we delay the mail sending, we can't send as the current user.
If we don't fill in the time.Time fields, datastore.Put will fail
because the zero time.Time value is out of its range.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6136053
 2012-05-01 11:33:25 +10:00
David Symonds
1bdb788b2e misc/dashboard/codereview: record Message-ID of code review thread mails. 
This will allow us to properly thread "R=..." mails at a later time.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6135053
 2012-04-30 22:47:51 +10:00
David Symonds
5d331964e7 misc/dashboard/codereview: add handy logout URL. 
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6135052
 2012-04-30 22:47:06 +10:00
David Symonds
4335ec9eeb misc/dashboard/codereview: send mail to assigned reviewers if they aren't already looped in. 
R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/6128054
 2012-04-30 22:03:56 +10:00
David Symonds
24cce5c60c misc/dashboard/codereview: don't depend on map iteration order for unit calculation. 
Fix auth requirements for /gc endpoint too.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6133049
 2012-04-28 09:47:15 +10:00
David Symonds
fe252584f5 misc/dashboard/codereview: simplify parallel operations for front page, and capture timing info. 
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6128044
 2012-04-27 23:16:54 +10:00
David Symonds
1a79053725 misc/dashboard/codereview: more abbreviated modification duration. 
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6131044
 2012-04-27 17:12:09 +10:00
David Symonds
0175e3f1e0 misc/dashboard/codereview: new app. 
This is live at http://gocodereview.appspot.com/.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6134043
 2012-04-27 16:36:02 +10:00