clones/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2024-09-30 06:47:04 +00:00
Code Issues Packages Projects Releases Wiki Activity
3,049 Commits 59 Branches 428 Tags 464 MiB
1f1551f179
Commit Graph

300 Commits

Author SHA1 Message Date
Ken Thompson
1c7bee0567 bug 155 
R=r
OCL=29619
CL=29619
 2009-05-29 14:42:24 -07:00
Russ Cox
cc7c31baa4 64-bit integer math bugs 
R=r
DELTA=46  (46 added, 0 deleted, 0 changed)
OCL=29569
CL=29614
 2009-05-29 13:46:43 -07:00
Ken Thompson
3b37b02834 bug 149 
R=r
OCL=29612
CL=29612
 2009-05-29 13:44:30 -07:00
Ken Thompson
b3f303ec9a bug 153 
R=r
OCL=29479
CL=29479
 2009-05-27 18:37:02 -07:00
Russ Cox
18890eebbf fix bug154; tweak bug153 exit status 
R=ken
OCL=29448
CL=29448
 2009-05-27 10:16:13 -07:00
Robert Griesemer
fec0c01e7f floating point bug 
R=rsc
DELTA=35  (35 added, 0 deleted, 0 changed)
OCL=29442
CL=29444
 2009-05-27 09:57:44 -07:00
Robert Griesemer
c376d5d7fc bad error message 
TBR=rsc
DELTA=14  (14 added, 0 deleted, 0 changed)
OCL=29441
CL=29441
 2009-05-27 09:47:13 -07:00
Ken Thompson
646927e48a and the golden file 
R=r
OCL=29421
CL=29421
 2009-05-26 19:58:59 -07:00
Rob Pike
70d711dfb8 bug150 is fixed 
R=ken
OCL=29407
CL=29407
 2009-05-26 16:06:03 -07:00
Russ Cox
c2fa45b973 allow type name as key to accomodate anonymous fields. 
update tests.

R=ken
OCL=29207
CL=29207
 2009-05-21 16:31:10 -07:00
Russ Cox
b9159722dd add test for yesterday's interface rule change (interface/convert1.go). 
move interface tests to subdirectory.

R=r
DELTA=1632  (827 added, 804 deleted, 1 changed)
OCL=29181
CL=29191
 2009-05-21 13:46:20 -07:00
Russ Cox
2da5022bcf change representation of interface values. 
this is not a user-visible change.

before, all interface values were

	struct Itype {
		Sigt *type;
		Sigi *inter;
		void *method[n];
	}

	struct Iface {
		void *addr;
		Itype *itype;
	}

the itype is basically a vtable, but it's unnecessary
if the static type is interface{ }.
for interface values with static type empty, the
new representation is

	struct Eface {
		void *addr;
		Sigt *type;
	}

this complicates the code somewhat, but
it reduces the number of Itypes that
have to be computed and cached,
it opens up opportunities to avoid function
calls in a few common cases,
and it will make it possible to lay out
interface{} values at compile time,
which i think i'll need for the new reflection.

R=ken
OCL=28701
CL=29121
 2009-05-20 14:57:55 -07:00
Russ Cox
a2ea790b1b bug152: literal []slice{ } as range expression 
R=ken
OCL=28918
CL=28918
 2009-05-15 13:17:07 -07:00
Ian Lance Taylor
025506d0a3 A comparison of two values with a type equivalent to string 
gives an type mismatch error, although both values appear to
have the same type.

R=ken,rsc
DELTA=23  (23 added, 0 deleted, 0 changed)
OCL=28786
CL=28805
 2009-05-14 06:25:40 -07:00
Russ Cox
7cf30cd49e bug150 
R=ken
OCL=28785
CL=28785
 2009-05-13 18:05:27 -07:00
Russ Cox
917aa35f8f implications of stricter type equality: 
if both types are named, they must be
the same type (arising from the same
declaration).

R=r,gri
DELTA=44  (21 added, 4 deleted, 19 changed)
OCL=28436
CL=28577
 2009-05-08 15:40:14 -07:00
Robert Griesemer
b3b3e0da94 conversion bug 
R=r
DELTA=24  (24 added, 0 deleted, 0 changed)
OCL=28451
CL=28508
 2009-05-08 09:58:25 -07:00
Russ Cox
b5e212ffdd 6g: error messages 
replace "shape error across CALL" with more information.

x.go:7: not enough arguments to CALL
	a int, b int
	int
x.go:10: assignment count mismatch: 3 = 2
x.go:12: too many arguments to RETURN
	[no arguments expected]
	int, int, int

also leave type alone after conversion failure,
for later errors:

bug049.go:6: cannot convert nil constant to string
bug049.go:6: illegal types for operand: EQ
	string
	nil		# this used to be blank

R=ken
OCL=28405
CL=28407
 2009-05-07 10:29:35 -07:00
Robert Griesemer
cc35ca529b wrong type used for dynamic type test 
R=r
DELTA=40  (40 added, 0 deleted, 0 changed)
OCL=28308
CL=28311
 2009-05-05 17:05:58 -07:00
Russ Cox
b8dd218e2e bug117 is fixed in 6g; now an errchk 
R=r
DELTA=42  (20 added, 22 deleted, 0 changed)
OCL=28295
CL=28295
 2009-05-05 13:41:46 -07:00
Russ Cox
21c9f82f40 update convlit.go to current spec 
R=r
DELTA=17  (2 added, 9 deleted, 6 changed)
OCL=28286
CL=28286
 2009-05-05 11:23:39 -07:00
Russ Cox
83e976d53e bug146: array/slice conversion before I left missed conversions 
R=ken
OCL=28120
CL=28124
 2009-04-30 13:49:58 -07:00
Ian Lance Taylor
625866a977 Conversion from array to slices should work like assignment: 
you should be able to convert a pointer to an array to a
slice, you should not be able to convert an array to a slice.
Currently 6g works the other way around.

R=ken,rsc
DELTA=17  (17 added, 0 deleted, 0 changed)
OCL=28033
CL=28067
 2009-04-29 20:15:59 -07:00
Ken Thompson
91ce0ef8f3 bug 139 
R=r
OCL=27987
CL=27987
 2009-04-28 13:52:56 -07:00
Ken Thompson
f2714e38a4 bug131 has been fixed with no change 
R=r
OCL=27980
CL=27980
 2009-04-28 13:04:01 -07:00
Ken Thompson
ad36c39211 bug 145 
R=r
OCL=27979
CL=27979
 2009-04-28 12:28:31 -07:00
Robert Griesemer
eaba458ee6 cannot declare a variable in new scope with same name as type in outer scope 
(same as bug144.go but for types instead of constants)

TBR=ken
DELTA=17  (17 added, 0 deleted, 0 changed)
OCL=27855
CL=27855
 2009-04-25 13:41:56 -07:00
Ken Thompson
b03b541b7a recognize a defined constant 
as a new name in a later declaration
(bug 144)

R=r
OCL=27850
CL=27850
 2009-04-24 16:43:31 -07:00
Robert Griesemer
516bf6535c - cannot declare local variable named like a constant in outer scope 
- submitted per discussion w/ ken

TBR=ken
DELTA=25  (25 added, 0 deleted, 0 changed)
OCL=27824
CL=27826
 2009-04-23 21:54:07 -07:00
Rob Pike
227fe8c530 bug143 is fixed 
R=dsymonds
DELTA=58  (26 added, 32 deleted, 0 changed)
OCL=27698
CL=27698
 2009-04-21 18:11:34 -07:00
Rob Pike
5689e6472c update golden for bug 143 
R=dsymonds
DELTA=6  (6 added, 0 deleted, 0 changed)
OCL=27654
CL=27654
 2009-04-21 00:05:19 -07:00
Russ Cox
a62467af93 fix stringrange test 
R=ken
OCL=27353
CL=27353
 2009-04-13 05:31:44 -07:00
Rob Pike
54ec719391 fix string range to have full unicode range (up to 10FFFF). 
add test for string range.

test has minor failure: after loop the index == len(s); should be len(s)-1
in this case.  according to spec, vars are left at position at last
iteration.

R=ken,rsc
DELTA=259  (161 added, 96 deleted, 2 changed)
OCL=27343
CL=27343
 2009-04-12 17:01:17 -07:00
Rob Pike
72d867660d bug142 is fixed 
R=rsc
OCL=27331
CL=27331
 2009-04-10 17:58:10 -07:00
Rob Pike
7d6c0018fb messages changed; updated golden.out for bug037 
R=rsc
OCL=27248
CL=27248
 2009-04-08 23:34:44 -07:00
Russ Cox
b8035ab5a5 bug142 
R=ken
OCL=27202
CL=27202
 2009-04-07 23:30:59 -07:00
Russ Cox
3067781ab9 func f() (int, int); 
x := f();

used to give
	fatal error: dowidth fn struct struct { int; int }

now gives
	assignment count mismatch: 1 = 2

R=ken
OCL=27198
CL=27201
 2009-04-07 22:20:37 -07:00
Rob Pike
a888d4d233 not a bug by current understanding, so delete this file. 
6g says: bug138.go:8: constant -1 overflows uint
gccgo says: bug138.go:8:16: error: integer constant overflow

R=rsc
DELTA=19  (0 added, 19 deleted, 0 changed)
OCL=27099
CL=27149
 2009-04-07 00:15:49 -07:00
Russ Cox
a99a7f60c3 tests changed - throw calls panic directly now 
instead of dereferencing nil, so no more SIGSEGVs.

R=r
DELTA=28  (0 added, 14 deleted, 14 changed)
OCL=26881
CL=26881
 2009-03-30 00:28:08 -07:00
Ken Thompson
a805e54a38 golden 
R=r
OCL=26699
CL=26699
 2009-03-24 16:47:33 -07:00
Rob Pike
7525e085d2 bug141 is fixed 
R=ken
DELTA=56  (26 added, 30 deleted, 0 changed)
OCL=26628
CL=26628
 2009-03-22 21:02:17 -07:00
Ian Lance Taylor
90943c8ee4 Test that interfaces work in type switches. 
R=ken,rsc
DELTA=30  (30 added, 0 deleted, 0 changed)
OCL=26599
CL=26604
 2009-03-20 16:30:54 -07:00
Ian Lance Taylor
1e39143966 Don't try to define the same label twice, as that produces a 
label redefinition error.

R=gri
DELTA=6  (0 added, 0 deleted, 6 changed)
OCL=26357
CL=26372
 2009-03-16 21:47:38 -07:00
Robert Griesemer
5a27079801 spec and implementation disagree with respect to label declarations 
R=rsc
DELTA=19  (19 added, 0 deleted, 0 changed)
OCL=26284
CL=26336
 2009-03-16 11:21:58 -07:00
Robert Griesemer
b260916a55 internal compiler error 
R=rsc
DELTA=18  (18 added, 0 deleted, 0 changed)
OCL=26266
CL=26266
 2009-03-13 14:14:50 -07:00
Russ Cox
5fbadf0bc3 warn -> yyerror in mparith. 
close two more bugs.

R=ken
OCL=26226
CL=26226
 2009-03-12 19:57:30 -07:00
Russ Cox
8f194bf5ff make 6g constants behave as ken proposes. (i hope.) 
various bug fixes and tests involving constants.

test/const1.go is the major new test case.

R=ken
OCL=26216
CL=26224
 2009-03-12 19:04:38 -07:00
Ken Thompson
767845b6fa bug 125 
R=r
OCL=26146
CL=26146
 2009-03-11 17:37:04 -07:00
Ken Thompson
48f6b516e2 bug 137 
R=r
OCL=26142
CL=26142
 2009-03-11 16:25:45 -07:00
Russ Cox
4eb7ceba58 complain when trying to put T into an interface 
if T has pointer methods.  this is just a heuristic
but it catches the problem robert ran into and
lets me put the larger interface issues aside for
now.  found one bug in pretty.

R=ken
OCL=26141
CL=26141
 2009-03-11 16:06:17 -07:00
Ken Thompson
d27e9f528d bug086 
R=r
OCL=26090
CL=26090
 2009-03-10 19:16:31 -07:00
Robert Griesemer
b2e91a9a29 constant conversion of int (non-ideal) constant doesn't work 
R=rsc
DELTA=20  (20 added, 0 deleted, 0 changed)
OCL=26054
CL=26062
 2009-03-10 16:39:23 -07:00
Russ Cox
63985b489b bug085 bug129 
R=ken
OCL=25787
CL=25791
 2009-03-05 15:57:03 -08:00
Rob Pike
88b1f8594a bug130 is fixed 
R=ken
OCL=25448
CL=25448
 2009-02-25 16:31:42 -08:00
Russ Cox
d3d0c256be bug123 
R=ken
OCL=25075
CL=25075
 2009-02-16 17:44:05 -08:00
Russ Cox
9f8f2e6130 convert composite literals from { } to ( ). 
only non-trivial changes are in
	convlit1.go
	golden.out

R=gri
OCL=25019
CL=25024
 2009-02-13 14:48:32 -08:00
Robert Griesemer
920ab67b4c label declarations not handled properly 
R=rsc
DELTA=27  (27 added, 0 deleted, 0 changed)
OCL=25015
CL=25015
 2009-02-13 13:42:43 -08:00
Robert Griesemer
a85e06f302 bug: empty statement not properly recognized in conjunction w/ labels 
R=r
DELTA=14  (14 added, 0 deleted, 0 changed)
OCL=24610
CL=24610
 2009-02-06 16:45:37 -08:00
Russ Cox
b0009bef20 bug064 
make f(g()) work when g returns multiple
args with names different than f expects.

func swap(a, b int) (c, d int) {
	return b, a
}

swap(swap(1,2))

R=ken
OCL=24474
CL=24476
 2009-02-05 15:22:49 -08:00
Rob Pike
f9cc900ae8 bugs cleanup, including deleting one near-identical duplicate bug 
R=rsc
DELTA=52  (15 added, 37 deleted, 0 changed)
OCL=24274
CL=24274
 2009-02-03 16:59:26 -08:00
Russ Cox
4cf7711568 update go code tree to new func rules. 
R=r
DELTA=367  (111 added, 59 deleted, 197 changed)
OCL=23957
CL=23960
 2009-01-30 14:39:31 -08:00
Russ Cox
391425ae55 if take address of local, move to heap. 
heuristic to not print bogus strings.
fix one error message format.

R=ken
OCL=23849
CL=23851
 2009-01-29 17:38:58 -08:00
Rob Pike
712522a6d8 bug135 is fixed 
TBR=ken
OCL=23650
CL=23650
 2009-01-27 19:30:44 -08:00
Rob Pike
fa615a3b30 f, ok := i.(Foo) does not compile if i already is equivalent to Foo 
R=rsc
DELTA=18  (18 added, 0 deleted, 0 changed)
OCL=23544
CL=23547
 2009-01-26 18:35:18 -08:00
Russ Cox
4efad58d0a bug133 
R=ken
OCL=23528
CL=23528
 2009-01-26 16:57:24 -08:00
Ian Lance Taylor
2a4f4dd842 Add a test for a case where 6g thinks that a field is visible 
when it should not be.  I couldn't get this any simpler; the
error seems to have to do with the order of the imports in
bug2.go.

R=rsc
DELTA=26  (26 added, 0 deleted, 0 changed)
OCL=23450
CL=23482
 2009-01-26 09:59:59 -08:00
Russ Cox
a7f6d4066e implement new restrictions on what 
can be compared/hashed.

R=r
DELTA=351  (201 added, 80 deleted, 70 changed)
OCL=23423
CL=23481
 2009-01-26 09:56:42 -08:00
Russ Cox
61590c4c44 disallow P.t for lowercase t and not our package P. 
implement hiding lowercase methods m in
signatures by adding in a hash of the package name
to the type hash code.

remove remaining checks for internally-generated _ names:
they are all gone.

R=ken
OCL=23236
CL=23238
 2009-01-21 14:51:57 -08:00
Robert Griesemer
41644d7138 - duplicate struct field not diagnosed 
R=rsc
DELTA=16  (16 added, 0 deleted, 0 changed)
OCL=23224
CL=23229
 2009-01-21 14:11:54 -08:00
Russ Cox
f48cbfdf56 convert tests; nothing interesting. 
R=r
OCL=23012
CL=23014
 2009-01-16 16:12:14 -08:00
Ian Lance Taylor
c0f6144f1b Test that a const with an explicit type is not treated as 
having an abstract type.

R=gri
DELTA=11  (11 added, 0 deleted, 0 changed)
OCL=22829
CL=22832
 2009-01-15 11:23:35 -08:00
Ian Lance Taylor
9414681972 Test that interfaces are correctly handled by pointer and by 
value for large and small objects.  Currently one case fails
with 6g.

R=rsc
DELTA=150  (150 added, 0 deleted, 0 changed)
OCL=22823
CL=22827
 2009-01-15 10:15:34 -08:00
Russ Cox
51c3ac7e3f bug046 and bug080 are fixed 
R=r
DELTA=72  (30 added, 42 deleted, 0 changed)
OCL=22373
CL=22378
 2009-01-08 20:06:37 -08:00
Russ Cox
5564504507 new new & make 
R=r
OCL=22166
CL=22166
 2009-01-06 15:19:02 -08:00
Rob Pike
315033368e bug020 is fixed 
R=rsc
DELTA=40  (18 added, 22 deleted, 0 changed)
OCL=22134
CL=22139
 2009-01-06 13:44:44 -08:00
Ian Lance Taylor
3f69acfb0c Test for a go statement which calls a method on an interface. 
R=ken
DELTA=20  (20 added, 0 deleted, 0 changed)
OCL=21889
CL=21929
 2008-12-30 15:03:46 -08:00
Russ Cox
e53d5ad620 fix type/name thing, again 
R=r
DELTA=8  (7 added, 0 deleted, 1 changed)
OCL=21379
CL=21379
 2008-12-16 17:45:28 -08:00
Rob Pike
0816debdfc update tests - 119 is fixed 
R=gri
DELTA=62  (28 added, 34 deleted, 0 changed)
OCL=21269
CL=21271
 2008-12-16 10:31:08 -08:00
Rob Pike
58a320f926 test update 
R=rsc
DELTA=16  (5 added, 10 deleted, 1 changed)
OCL=21085
CL=21087
 2008-12-12 13:29:25 -08:00
Russ Cox
889d9b6ffd bug129 
package foo
import "syscall"
func f() {
	syscall := 1
}

R=ken
OCL=21036
CL=21036
 2008-12-11 18:19:07 -08:00
Rob Pike
77fbc310e4 another bug cleanup. 
R=rsc
DELTA=117  (54 added, 62 deleted, 1 changed)
OCL=20924
CL=20927
 2008-12-10 14:59:43 -08:00
Rob Pike
fbfc9dddb2 update tests: nil is no longer integer-compatible 
R=rsc
DELTA=56  (17 added, 32 deleted, 7 changed)
OCL=20876
CL=20916
 2008-12-10 13:55:47 -08:00
Rob Pike
94a66489ed bug128 is fixed 
R=rsc
DELTA=43  (19 added, 24 deleted, 0 changed)
OCL=20551
CL=20551
 2008-12-04 20:51:47 -08:00
Russ Cox
dfa5893d4f preparation for exec. 
* syscall:
	add syscall.RawSyscall, which doesn't use sys.entersyscall/sys.exitsyscall
	add syscall.dup2
	add syscall.BytePtrPtr
	add syscall.Rusage, RusagePtr
	add syscall.F_GETFD, F_SETFD, FD_CLOEXEC

* runtime:
	clean up, correct signal handling.
	can now survive (continue running after) a signal.

R=r
DELTA=394  (286 added, 51 deleted, 57 changed)
OCL=20351
CL=20369
 2008-12-03 14:21:28 -08:00
Russ Cox
98431dbfff golden.out drift 
TBR=r
OCL=20352
CL=20355
 2008-12-03 13:05:56 -08:00
Robert Griesemer
4d76e8e142 - bug: empty switches don't compile 
R=rsc
DELTA=32  (28 added, 3 deleted, 1 changed)
OCL=20301
CL=20340
 2008-12-03 10:41:43 -08:00
Robert Griesemer
b0192ea1a5 bug: constants should not be redeclarable 
R=rsc
DELTA=9  (9 added, 0 deleted, 0 changed)
OCL=20187
CL=20187
 2008-12-01 17:27:57 -08:00
Rob Pike
60db3d6d3f don't print (incorrect anyway) line numbers in panic. 
R=rsc
DELTA=4  (0 added, 2 deleted, 2 changed)
OCL=19757
CL=19763
 2008-11-20 23:16:31 -08:00
Russ Cox
6cc001c312 return *os.Error instead of bool from strconv.ato* 
R=r
DELTA=137  (56 added, 4 deleted, 77 changed)
OCL=19505
CL=19522
 2008-11-18 17:12:07 -08:00
Robert Griesemer
6c5fc055c8 import syntax incorrect 
R=r
OCL=19457
CL=19457
 2008-11-18 09:39:34 -08:00
Russ Cox
c78005f648 update golden.out 
R=r
OCL=19455
CL=19455
 2008-11-18 09:35:42 -08:00
Ian Lance Taylor
d8ecead73d The compiler should reject calling a const as though it were a 
function.  Also update golden.out.

R=r
DELTA=18  (18 added, 0 deleted, 0 changed)
OCL=19433
CL=19448
 2008-11-18 06:25:21 -08:00
Russ Cox
a1585b676b fix the easy parts of bug120 
R=r,ken
DELTA=66  (52 added, 3 deleted, 11 changed)
OCL=19386
CL=19389
 2008-11-17 13:58:45 -08:00
Russ Cox
869c3f4cd0 update golden.out. 
fix bug in run that was missing output.
make run warn about tests in bugs/ that succeed with no output
	(should be moved to fixedbugs/).

R=r
DELTA=21  (18 added, 0 deleted, 3 changed)
OCL=19381
CL=19381
 2008-11-17 12:44:22 -08:00
Ian Lance Taylor
b1e8b5f5b7 The scope rules have been clarified to indicate that a 
variable may only be named after the complete declaration,
including the initialization statements.

R=gri
DELTA=61  (16 added, 45 deleted, 0 changed)
OCL=19343
CL=19376
 2008-11-17 12:19:02 -08:00
Ian Lance Taylor
7dee51f491 The compilers should and do permit interface types to list 
multiple method names with a single type.

R=r,gri
DELTA=10  (0 added, 10 deleted, 0 changed)
OCL=19292
CL=19298
 2008-11-14 17:28:17 -08:00
Ian Lance Taylor
c4d8dc0b83 This bug has been fixed; moving it from bugs to fixedbugs. 
R=gri
DELTA=36  (18 added, 18 deleted, 0 changed)
OCL=19059
CL=19133
 2008-11-12 21:59:43 -08:00
Ian Lance Taylor
a957ceec35 The scope rules have been changed to say that labels live in a 
separate per-function namespace.

R=gri
DELTA=24  (8 added, 16 deleted, 0 changed)
OCL=19006
CL=19057
 2008-11-11 18:17:54 -08:00
Rob Pike
203a17c6ec update tests 
R=gri
DELTA=28  (12 added, 14 deleted, 2 changed)
OCL=18923
CL=18923
 2008-11-10 14:59:15 -08:00
Ian Lance Taylor
9c7374d71b Erroneous test case. The break statement should break out of 
a select clause.

R=ken
DELTA=20  (0 added, 20 deleted, 0 changed)
OCL=18731
CL=18739
 2008-11-06 17:39:48 -08:00