Commit Graph

126 Commits

Author SHA1 Message Date
Robert Griesemer
1f9dfa294f go AST: First step towards augmenting AST with full type information.
- change ast.Ident back to contain the name and adjust all dependent code
- identifier object information will be added again through an optional
  typechecker phase (in the works).
- remove tracking of scopes in parser - it's easier to do this in a separate
  phase (in the works)
- in godoc, generate popup info table directly instead of through a formatter
  for simpler data flow (at the expense of a little bit more code)

Runs all tests.

As a result of this change, the currently shown popup information
(const, var, type, func, followed by identifier name) will not be
shown anymore temporarily.

R=rsc
CC=golang-dev
https://golang.org/cl/1994041
2010-08-13 10:42:18 -07:00
Russ Cox
7886318ca0 codereview: do not send "Abanoned" mail if this CL has
not been mailed out for review.

R=r
CC=golang-dev
https://golang.org/cl/1962046
2010-08-12 14:58:38 -07:00
Ivan Krasin
e8b8aeb02a codereview.py: Fix issues with leading tabulation in the Files: section of CL description.
R=imkrasin, rsc
CC=golang-dev
https://golang.org/cl/1943042
2010-08-12 00:04:17 -07:00
Andrew Gerrand
bab711b184 doc: update front page and go_learning.html
This is a stop-gap change to give more current information visibility
before a more thorough reorganization.

R=r, rsc, gri
CC=golang-dev
https://golang.org/cl/1902042
2010-07-30 10:36:13 +10:00
Russ Cox
bbf925aa56 codereview: avoid crash if no config
Fixes #959.

R=r
CC=golang-dev
https://golang.org/cl/1876045
2010-07-26 17:33:50 -07:00
Russ Cox
08e65f79c1 codereview: make 'hg submit' work with Mercurial 1.6
R=r
CC=golang-dev
https://golang.org/cl/1841044
2010-07-16 18:54:38 -07:00
Russ Cox
ad665e4fde codereview: don't run gofmt with an empty file list
R=gri
CC=golang-dev
https://golang.org/cl/1678054
2010-07-15 16:43:06 -07:00
Evan Shaw
e8fcf60093 codereview: Fix for Mercurial >= 1.6
R=rsc, adg, rsc1
CC=golang-dev
https://golang.org/cl/1804041
2010-07-14 17:17:04 -07:00
Russ Cox
93f614ff86 codereview: allow multiple email addresses in CONTRIBUTORS
R=r
CC=golang-dev
https://golang.org/cl/1650041
2010-06-30 23:34:11 -07:00
Andrew Gerrand
4f340f5051 godoc: canonicalize codewalk paths
R=rsc
CC=golang-dev
https://golang.org/cl/1729046
2010-06-30 17:56:51 +10:00
Paolo Giarrusso
3ca72458ec codereview: avoid exception in match
R=rsc
CC=golang-dev
https://golang.org/cl/1585041
2010-06-09 21:37:11 -07:00
Andrew Gerrand
1ca99c84f8 golang.org: added Resources page, re-organized left hand panel.
R=r
CC=golang-dev
https://golang.org/cl/1309045
2010-05-27 16:47:42 -07:00
Peter Williams
1d6eb74697 codereview: work better with mq
R=rsc
CC=golang-dev
https://golang.org/cl/1140043
2010-05-24 14:37:00 -07:00
Russ Cox
2a591bdf8a godoc: add codewalk support
R=adg, gri
CC=golang-dev, r
https://golang.org/cl/1008042
2010-04-26 22:35:12 -07:00
David Symonds
ee75ffa286 codereview: Mention that deleting a CL is a use of 'hg change' in its header.
R=rsc
CC=golang-dev
https://golang.org/cl/903043
2010-04-10 01:53:43 -07:00
Robert Griesemer
e8e4987ba3 godoc: support for title and subtitle headers when serving .html docs
and use it to show version (date) of go spec

Fixes #68.

R=rsc
CC=golang-dev, r
https://golang.org/cl/848042
2010-03-30 17:37:42 -07:00
Robert Griesemer
acfd6d5f05 godoc: show relative file names without leading '/' (per r's request)
- change the various url-xxx formatters to return a relative URL path
- make the leading '/' for URLs explicit in the template
- on the way change some |html formatters to |html-esc
  (html should only be used for formatting AST nodes)

R=rsc, r
CC=golang-dev
https://golang.org/cl/740041
2010-03-24 16:28:59 -07:00
Robert Griesemer
6c8fdbe8c7 godoc: line numbers for all remote search results
Instead of returning the index lookup result via
RPC which has to be corrected for the client,
simply render it on the server and return the
final output.

R=rsc, r
CC=golang-dev
https://golang.org/cl/669041
2010-03-19 22:48:08 -07:00
Russ Cox
e8fb0b014c godoc: revert change 5089, per gri's instructions
R=gri
CC=golang-dev
https://golang.org/cl/630043
2010-03-19 17:46:18 -07:00
Andrew Gerrand
7190fdd3bf website: add Go Blog widget to frontpage,
add Blog and Wiki links to sideba

R=r, rsc, gri
CC=golang-dev
https://golang.org/cl/611042
2010-03-20 11:42:57 +11:00
Robert Griesemer
b037bfa684 godoc: proper file path conversion for remote search
R=rsc
CC=golang-dev
https://golang.org/cl/664041
2010-03-19 17:07:16 -07:00
Robert Griesemer
fa462f37e3 godoc: show (some) line numbers for remote search
- show build version
- use build goroot when possible

R=rsc
CC=golang-dev
https://golang.org/cl/656043
2010-03-19 15:20:20 -07:00
Robert Griesemer
17e0351404 godoc: implemented command-line search
The command-line search is using a running webserver
as index server; i.e., the search result is reflecting
the index at the server. See the documentation for
details.

Usage: godoc -q query1 query2 ...

Known issue: Results don't show the all-important
line numbers yet due to the way the index is organized.
Next CL.

R=rsc, r
CC=golang-dev
https://golang.org/cl/648041
2010-03-19 12:46:43 -07:00
Robert Griesemer
74fac99d05 godoc: initial support for showing popup information
for identifiers in Go source code

- at the moment just show identifier kind (var, func, etc.) and name
  (eventually should show declaration, type, etc.)
- JavaScript parts by adg

R=rsc
CC=adg, golang-dev
https://golang.org/cl/578042
2010-03-16 14:17:42 -07:00
Robert Griesemer
226c2ec256 godoc: support for multiple packages in a directory
- smartly select the "right" package
- provide a list of other packages

R=rsc
CC=golang-dev
https://golang.org/cl/466042
2010-03-12 18:16:21 -08:00
Robert Griesemer
35aec6c7f7 godoc: provide mode which shows exported interface in "source form"
- on the commandline: godoc -x big
- in a webpage: provide form parameter ?m=src

Known issues:
- Positioning of comments incorrect in several cases. Separate CL.
- Need a link/menu to switch between different modes of presentation
  in the web view.

R=rsc
CC=golang-dev
https://golang.org/cl/376041
2010-03-10 15:22:22 -08:00
Andrew Gerrand
1d5af1553c First run at a Programming FAQ
Moved a couple of FAQs from the main FAQ, and added some others

R=r, rsc, iant, gri
CC=golang-dev
https://golang.org/cl/218070
2010-03-04 12:56:08 +11:00
Andrew Gerrand
e678afa891 codereview.py: fix for compatibility with hg >=1.4.3
hg.parseurl now returns a two-value tuple; codereview.py expected 3.
Changed to merely take the first return value.

R=rsc, iant
CC=golang-dev
https://golang.org/cl/223087
2010-03-03 09:03:31 +11:00
Robert Griesemer
a5c29da313 remove absolute paths from search results
R=adg
CC=golang-dev
https://golang.org/cl/216053
2010-02-19 10:09:20 -08:00
Robert Griesemer
d17ffb9753 godoc: path cleanups, fixed a race condition, initial support for a menu on pages
R=rsc
CC=adg, golang-dev
https://golang.org/cl/215050
2010-02-18 17:40:50 -08:00
Robert Griesemer
5883c6ef1f godoc support for directories outside $GOROOT
Example use: godoc -path=/home/user1:/home/build/foo -http=:6666
will start a local godoc that maps urls starting with /pkg/user1 or
/pkg/foo to the respective roots specified in the path.

Missing: Handling of overlapping package directories, multiple
packages per directory.

R=rsc
CC=golang-dev
https://golang.org/cl/206078
2010-02-16 11:20:55 -08:00
Russ Cox
4967f857d5 codereview: make sure each mail has a reviewer
R=r
CC=golang-dev
https://golang.org/cl/196050
2010-01-28 12:48:21 -08:00
Russ Cox
84b044e8fb codereview: correct handling of files created with hg cp
R=r
CC=golang-dev
https://golang.org/cl/194118
2010-01-27 16:14:11 -08:00
Russ Cox
ff7343f8d0 codereview: accommodate recent change to ui.prompt
Fixes #525.

R=r
CC=golang-dev
https://golang.org/cl/190044
2010-01-20 09:49:35 -08:00
Russ Cox
6c2e0fe1f9 create doc/talks/.
move talk-20091030 down.
add talk given at Stanford 2010/01/12.
add doc/go-logo-white.png.

R=r
CC=golang-dev
https://golang.org/cl/186132
2010-01-13 16:26:22 -08:00
Robert Griesemer
27be2915f3 Distinguish between html generation and html quoting in godoc formatters.
Replacement for CL 184084; originally by Roger Peppe (rogpeppe@gmail.com).

R=rsc
CC=golang-dev, rog
https://golang.org/cl/189059
2010-01-13 15:18:56 -08:00
Russ Cox
1c6c0eee20 godoc: skip template wrapping for complete HTML files
demo at http://wreck:8080/doc/
click on go_talk-20100112.html

R=gri
CC=golang-dev
https://golang.org/cl/186137
2010-01-13 13:09:33 -08:00
Russ Cox
84ac357c79 codereview: split name list only on commas; some user names have spaces
R=r
CC=golang-dev
https://golang.org/cl/184069
2010-01-13 09:09:06 -08:00
Russ Cox
752b1702d0 codereview: do not send mail when submitting for others
rename original_author to copied_from so that it reads
better when used as a condition.

R=r
CC=golang-dev
https://golang.org/cl/185045
2010-01-09 09:47:14 -08:00
Russ Cox
c918c41c58 add doc/devel/index.html, linked from nav bar
R=r
CC=golang-dev
https://golang.org/cl/181156
2010-01-07 18:23:41 -08:00
Russ Cox
1594730461 codereview: repeated hg mail sends "PTAL"
also send out hg mail for TBR submits

R=r
CC=golang-dev
https://golang.org/cl/183137
2010-01-07 18:23:30 -08:00
Russ Cox
8274742393 codereview: add golang-dev@googlegroups.com
automatically in "hg mail".
also, avoid "empty list means all modified files in client" bug

R=gri, cw
CC=golang-dev
https://golang.org/cl/174072
2009-12-15 13:36:05 -08:00
Hector Chu
31645cc0bb Ported godefs to Windows.
R=rsc
https://golang.org/cl/164049
2009-12-13 12:21:44 -08:00
Russ Cox
d55abfd2c9 doc: split contribute.html into code.html and contribute.html
R=r
https://golang.org/cl/170042
2009-12-09 14:05:12 -08:00
Russ Cox
9a86cc679a codereview: do not gofmt deleted files
R=r
https://golang.org/cl/164083
2009-12-03 17:23:11 -08:00
Russ Cox
69f893a127 codereview: move reviewers to cc line after submit,
so that the issue stops showing up on the
  per-reviewer dashboard page.

R=r
https://golang.org/cl/164075
2009-12-02 09:10:59 -08:00
Devon H. O'Dell
e9a8ab031d lxml.etree is the wrong location for this alt package
on my linux machine this is the correct one. lxml.etree
  exists with an ElementTree class, but does not contain
  an .XML method.

R=rsc
https://golang.org/cl/163082
2009-12-02 08:18:26 -08:00
Devon H. O'Dell
742221d20b xml.etree can also be lxml.etree (e.g. CentOS 5.4 with Python 2.4.3)
R=rsc
CC=golang-dev
https://golang.org/cl/164053
2009-12-02 01:16:38 -08:00
Robert Griesemer
9e450880e9 some godoc cleanup:
- simplified dealing with parse errors: no need to intersperse them in the source
- improve visibility of highlighted identifiers by showing them in bold

R=rsc
https://golang.org/cl/163051
2009-12-01 09:15:05 -08:00
Hector Chu
cd9d72ba9e Ports of lib9, libbio and libmach to Windows.
R=rsc
https://golang.org/cl/157159
2009-11-30 11:53:11 -08:00