From f3c89e21a566a6c82cff3e4d4b30e21de22a84fa Mon Sep 17 00:00:00 2001 From: Tobias Klauser Date: Thu, 12 Sep 2024 14:47:32 +0200 Subject: [PATCH] cmd/link/internal: use slices.Contains Change-Id: Ib437e272e0eb7d1b0969a4ed94d264ca3aad7c59 Reviewed-on: https://go-review.googlesource.com/c/go/+/612696 LUCI-TryBot-Result: Go LUCI Auto-Submit: Tim King Auto-Submit: Tobias Klauser Reviewed-by: Ian Lance Taylor Reviewed-by: Tim King --- src/cmd/link/internal/ld/lib.go | 5 +++-- src/cmd/link/internal/ld/util.go | 10 ---------- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/src/cmd/link/internal/ld/lib.go b/src/cmd/link/internal/ld/lib.go index 643356d602..e43fc11b12 100644 --- a/src/cmd/link/internal/ld/lib.go +++ b/src/cmd/link/internal/ld/lib.go @@ -44,6 +44,7 @@ import ( "os/exec" "path/filepath" "runtime" + "slices" "sort" "strings" "sync" @@ -2182,9 +2183,9 @@ func trimLinkerArgv(argv []string) []string { } else if skip { skip = false } else if f == "" || f[0] != '-' { - } else if contains(flagsWithNextArgSkip, f) { + } else if slices.Contains(flagsWithNextArgSkip, f) { skip = true - } else if contains(flagsWithNextArgKeep, f) { + } else if slices.Contains(flagsWithNextArgKeep, f) { flags = append(flags, f) keep = true } else { diff --git a/src/cmd/link/internal/ld/util.go b/src/cmd/link/internal/ld/util.go index 63b7e0d329..9873a50dcc 100644 --- a/src/cmd/link/internal/ld/util.go +++ b/src/cmd/link/internal/ld/util.go @@ -105,13 +105,3 @@ func stringtouint32(x []uint32, s string) { x[i] = binary.LittleEndian.Uint32(buf[:]) } } - -// contains reports whether v is in s. -func contains(s []string, v string) bool { - for _, x := range s { - if x == v { - return true - } - } - return false -}