clones/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2024-09-21 18:38:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

os: don't fail TestGetwdDeepWithPWDSet if TMPDIR has a symlink

Browse Source 
When testing with PWD set, it's possible for the stat of PWD to fail
with ENAMETOOLONG, and for syscall.Getwd to fail for the same reason.
If PWD contains symlinks, the fallback code won't know about them.
If Getwd returns the same result as PWD with resolved symlinks,
the test should not fail.

Change-Id: I39587ddb826d4e18339e185aad0cdd60167b1079
Reviewed-on: https://go-review.googlesource.com/c/go/+/610759
Auto-Submit: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Commit-Queue: Ian Lance Taylor <iant@google.com>
Reviewed-by: Tim King <taking@google.com>
This commit is contained in:
Ian Lance Taylor 2024-09-04 15:57:51 -07:00 committed by Gopher Robot
parent a2891aef75
commit d102c2ed01
1 changed files with 21 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/os/getwd_unix_test.go
View File

@ -9,6 +9,7 @@ package os_test
import ( import (
"errors" "errors"
. "os" . "os"
"path/filepath"
"runtime" "runtime"
"strings" "strings"
"syscall" "syscall"
@ -26,7 +27,9 @@ func TestGetwdDeepWithPWDSet(t *testing.T) {
// testGetwdDeep checks that os.Getwd is able to return paths // testGetwdDeep checks that os.Getwd is able to return paths
// longer than syscall.PathMax (with or without PWD set). // longer than syscall.PathMax (with or without PWD set).
func testGetwdDeep(t *testing.T, setPWD bool) { func testGetwdDeep(t *testing.T, setPWD bool) {
dir := t.TempDir() tempDir := t.TempDir()
dir := tempDir
t.Chdir(dir) t.Chdir(dir)
if setPWD { if setPWD {
@ -66,7 +69,23 @@ func testGetwdDeep(t *testing.T, setPWD bool) {
t.Fatal(err) t.Fatal(err)
} }
if setPWD && wd != dir { if setPWD && wd != dir {
t.Fatalf("Getwd: want same value as $PWD: %q, got %q", dir, wd) // It's possible for the stat of PWD to fail
// with ENAMETOOLONG, and for getwd to fail for
// the same reason, and it's possible for $TMPDIR
// to contain a symlink. In that case the fallback
// code will not return the same directory.
if len(dir) > 1000 {
symDir, err := filepath.EvalSymlinks(tempDir)
if err == nil && symDir != tempDir {
t.Logf("EvalSymlinks(%q) = %q", tempDir, symDir)
if strings.Replace(dir, tempDir, symDir, 1) == wd {
// Symlink confusion is OK.
break
}
}
}
t.Fatalf("Getwd: got %q, want same value as $PWD: %q", wd, dir)
} }
// Ideally the success criterion should be len(wd) > syscall.PathMax, // Ideally the success criterion should be len(wd) > syscall.PathMax,
// but the latter is not public for some platforms, so use Stat(wd). // but the latter is not public for some platforms, so use Stat(wd).