clones/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2024-09-21 18:38:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

internal/reflectlite: remove redundent ifaceIndir

Browse Source 
Use abi.(*Type).IfaceIndir instead.

Change-Id: I55a1a593d76601fb615d131abcf1b32012741e8c
GitHub-Last-Rev: 14de2a9d67
GitHub-Pull-Request: golang/go#67228
Reviewed-on: https://go-review.googlesource.com/c/go/+/583756
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@google.com>
This commit is contained in:
apocelipes 2024-05-07 13:32:42 +00:00 committed by Gopher Robot
parent 348b23830d
commit c637d4b939
3 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/internal/reflectlite/export_test.go
View File

@ -70,7 +70,7 @@ func Zero(typ Type) Value {
}
t := typ.common()
fl := flag(t.Kind())
if ifaceIndir(t) {
if t.IfaceIndir() {
return Value{t, unsafe_New(t), fl | flagIndir}
}
return Value{t, nil, fl}

5
src/internal/reflectlite/type.go
View File

@ -641,8 +641,3 @@ func toType(t *abi.Type) Type {
}
return toRType(t)
}
// ifaceIndir reports whether t is stored indirectly in an interface value.
func ifaceIndir(t *abi.Type) bool {
return abi.Kind(t.Kind_)&abi.KindDirectIface == 0
}

4
src/internal/reflectlite/value.go
View File

@ -116,7 +116,7 @@ func packEface(v Value) any {
e := (*abi.EmptyInterface)(unsafe.Pointer(&i))
// First, fill in the data portion of the interface.
switch {
case ifaceIndir(t):
case t.IfaceIndir():
if v.flag&flagIndir == 0 {
panic("bad indir")
}
@ -153,7 +153,7 @@ func unpackEface(i any) Value {
return Value{}
}
f := flag(t.Kind())
if ifaceIndir(t) {
if t.IfaceIndir() {
f |= flagIndir
}
return Value{t, e.Data, f}