clones/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2024-09-30 23:07:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

net: Fix race condition in test.

Browse Source 
The test code used to do this:

for _, tc := range tests {
	ch <- &tc
}

Note that &tc is always the same value here.  As the value is
received from the channel, the sender can loop around and
change the contents of tc.  This means that the receiver's
value is unstable and can change while it is in use.

R=adg, r2, rsc
CC=chris, golang-dev
https://golang.org/cl/3978043
This commit is contained in:
Ian Lance Taylor 2011-01-21 13:57:52 -08:00
parent 27c74d3499
commit 9e441e5215
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/pkg/net/dnsname_test.go
View File

@ -27,7 +27,7 @@ var tests = []testCase{
{"a.b..com", false},
}
func getTestCases(ch chan<- *testCase) {
func getTestCases(ch chan<- testCase) {
defer close(ch)
var char59 = ""
var char63 = ""
@ -39,17 +39,17 @@ func getTestCases(ch chan<- *testCase) {
char64 = char63 + "a"
for _, tc := range tests {
ch <- &tc
ch <- tc
}
ch <- &testCase{char63 + ".com", true}
ch <- &testCase{char64 + ".com", false}
ch <- testCase{char63 + ".com", true}
ch <- testCase{char64 + ".com", false}
// 255 char name is fine:
ch <- &testCase{char59 + "." + char63 + "." + char63 + "." +
ch <- testCase{char59 + "." + char63 + "." + char63 + "." +
char63 + ".com",
true}
// 256 char name is bad:
ch <- &testCase{char59 + "a." + char63 + "." + char63 + "." +
ch <- testCase{char59 + "a." + char63 + "." + char63 + "." +
char63 + ".com",
false}
}
@ -58,7 +58,7 @@ func TestDNSNames(t *testing.T) {
if runtime.GOOS == "windows" {
return
}
ch := make(chan *testCase)
ch := make(chan testCase)
go getTestCases(ch)
for tc := range ch {
if isDomainName(tc.name) != tc.result {