clones/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2024-09-22 10:58:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/compile/internal/types2: reduce output when describing type parameters

Browse Source 
There's no need to say "type parameter" for a type parameter. The
name is sufficient (they are always named), and the prose is followed
by "constrained by".

Change-Id: I98df8caa1432b8b7a874e58da6e3ed6be102b4a0
Reviewed-on: https://go-review.googlesource.com/c/go/+/357410
Trust: Robert Griesemer <gri@golang.org>
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
This commit is contained in:
Robert Griesemer 2021-10-20 13:12:43 -07:00
parent ff8115d1a1
commit 76dd01f457
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/cmd/compile/internal/types2/operand.go
View File

@ -176,17 +176,14 @@ func operandString(x *operand, qf Qualifier) string {
if hasType { if hasType {
if x.typ != Typ[Invalid] { if x.typ != Typ[Invalid] {
var intro string var intro string
var tpar *TypeParam
if isGeneric(x.typ) { if isGeneric(x.typ) {
intro = " of parameterized type " intro = " of parameterized type "
} else if tpar = asTypeParam(x.typ); tpar != nil {
intro = " of type parameter "
} else { } else {
intro = " of type " intro = " of type "
} }
buf.WriteString(intro) buf.WriteString(intro)
WriteType(&buf, x.typ, qf) WriteType(&buf, x.typ, qf)
if tpar != nil { if tpar := asTypeParam(x.typ); tpar != nil {
buf.WriteString(" constrained by ") buf.WriteString(" constrained by ")
WriteType(&buf, tpar.bound, qf) // do not compute interface type sets here WriteType(&buf, tpar.bound, qf) // do not compute interface type sets here
} }