clones/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2024-09-22 02:48:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/go/internal/modfetch: comment on known bug in isVendoredPackage

Browse Source 
Fixes #31562

Change-Id: Ida30dd8071eccb6b490ab89a1de087038fe26796
Reviewed-on: https://go-review.googlesource.com/c/go/+/172977
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
This commit is contained in:
Bryan C. Mills 2019-04-19 10:15:58 -04:00
parent 64e29f94e2
commit 47150aafbf
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/cmd/go/internal/modfetch/coderepo.go
View File

@ -634,6 +634,19 @@ func isVendoredPackage(name string) bool {
if strings.HasPrefix(name, "vendor/") { if strings.HasPrefix(name, "vendor/") {
i += len("vendor/") i += len("vendor/")
} else if j := strings.Index(name, "/vendor/"); j >= 0 { } else if j := strings.Index(name, "/vendor/"); j >= 0 {
// This offset looks incorrect; this should probably be
//
// i = j + len("/vendor/")
//
// (See https://golang.org/issue/31562.)
//
// Unfortunately, we can't fix it without invalidating checksums.
// Fortunately, the error appears to be strictly conservative: we'll retain
// vendored packages that we should have pruned, but we won't prune
// non-vendored packages that we should have retained.
//
// Since this defect doesn't seem to break anything, it's not worth fixing
// for now.
i += len("/vendor/") i += len("/vendor/")
} else { } else {
return false return false