clones/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2024-09-21 10:28:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

time: check for time zone offset overflow

Browse Source 
Fixes #67470

Change-Id: Idc5997859602ff6155aa9ae875b327fbcb53513d
Reviewed-on: https://go-review.googlesource.com/c/go/+/586717
Reviewed-by: Alan Donovan <adonovan@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Commit-Queue: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
Ian Lance Taylor 2024-05-19 21:48:40 -07:00 committed by Gopher Robot
parent 726fd5bc2b
commit 1849ce6a45
2 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/time/format.go
View File

@ -1242,6 +1242,20 @@ func parse(layout, value string, defaultLocation, local *Location) (Time, error)
if err == nil {
ss, _, err = getnum(seconds, true)
}
// The range test use > rather than >=,
// as some people do write offsets of 24 hours
// or 60 minutes or 60 seconds.
if hr > 24 {
rangeErrString = "time zone offset hour"
}
if mm > 60 {
rangeErrString = "time zone offset minute"
}
if ss > 60 {
rangeErrString = "time zone offset second"
}
zoneOffset = (hr*60+mm)*60 + ss // offset is in seconds
switch sign[0] {
case '+':

10
src/time/format_test.go
View File

@ -661,6 +661,16 @@ var parseErrorTests = []ParseErrorTest{
{"06-01-02", "a2-10-25", `parsing time "a2-10-25" as "06-01-02": cannot parse "a2-10-25" as "06"`},
{"03:04PM", "12:03pM", `parsing time "12:03pM" as "03:04PM": cannot parse "pM" as "PM"`},
{"03:04pm", "12:03pM", `parsing time "12:03pM" as "03:04pm": cannot parse "pM" as "pm"`},
// issue 67470
{"-07", "-25", "time zone offset hour out of range"},
{"-07:00", "+25:00", "time zone offset hour out of range"},
{"-07:00", "-23:61", "time zone offset minute out of range"},
{"-07:00:00", "+23:59:61", "time zone offset second out of range"},
{"Z07", "-25", "time zone offset hour out of range"},
{"Z07:00", "+25:00", "time zone offset hour out of range"},
{"Z07:00", "-23:61", "time zone offset minute out of range"},
{"Z07:00:00", "+23:59:61", "time zone offset second out of range"},
}
func TestParseErrors(t *testing.T) {