Commit Graph

112 Commits

Author SHA1 Message Date
Louis-Maxime Piton
5010e8d73e
Fix the focus ring on focused checked buttons (#39595) 2024-02-06 21:59:42 +02:00
Giovanni Piller Cottrer
d1d49ffe1d
New $btn-link-focus-shadow-rgb for color modes customisation (#39119) 2023-09-13 09:18:07 +02:00
lavsemen
9a1f4ed9e5
Fix button visibility issue on dark theme (#38115)
* Fix button visibility issue on dark theme

* Add $btn-color-variable in _buttons.scss

* Apply suggestions from code review

---------

Co-authored-by: Семен Лаверентьев <remark.lavrentev@gmail.com>
Co-authored-by: Mark Otto <otto@github.com>
2023-03-02 10:49:54 -08:00
Serhii Babakov
d576590632 Fix shadow of .btn-link 2023-02-20 15:17:08 +04:00
Mark Otto
eb10b7079c Switch from none keyword value to a fake shadow for btn-link 2023-01-06 11:48:28 -08:00
Patrick H. Lauke
2be9cd59ba
Explicitly target .btn-check and undo :hover (#37165)
rather than the other way around, which caused specificity issues
2022-09-20 15:15:46 +02:00
Mark Otto
2504b89950 Remove gradient from .btn-link 2022-09-04 11:12:38 -07:00
Patrick H. Lauke
32c457db4b
Rework button focus/active styling, with extra changes for checks/radios (#37026)
* Replace :focus styles with :focus-visible

* Remove :active / .active styles

* Don't apply :hover styles for `.btn` that follows a `.btn-check`

This removes a large part of the visual confusion of button checks/radios - that you currently have to move your mouse away from them to see what they actually changed to (checked or unchecked)

* Reintroduce :active, but *not* for button checks/radios

* Sort focus styling specifically for button checks/radios

don't change background on focus, just give it the border/outline. again, avoids confusion whether something is checked or not while focused

* Re-add `outline:0` which was lost when resolving last merge conflict

Co-authored-by: Mark Otto <markd.otto@gmail.com>
2022-09-04 09:59:14 -07:00
Patrick H. Lauke
cda901f244
v5/docs: reintroduce outline for docs code samples, buttons when :not(:focus-visible) (#36507)
* Remove outline suppression for focused `<pre>`

Sighted keyboard users rely on knowing where their focus is. If the `<pre>` receives focus (so that it can be scrolled by keyboard users, for instance) then it's essential that they know this is the case

* Only suppress outline for buttons when `:not(:focus-visible)`

* Add right-hand margin to pre

avoids having the focus outline awkwardly clipped by the copy button
2022-08-31 18:30:23 -07:00
Michael Geuchmann
bc2ec7c758 bugfix undefined border color variable for btn 2022-08-31 18:12:01 -07:00
Julien Déramond
150b374933 Fix active/focused button link text color 2022-07-17 20:52:52 -07:00
Mark Otto
d16a16258c Manually set hover and active backgrounds and borders for dark and light buttons 2022-06-08 15:32:05 -07:00
Mark Otto
427c089961 Stylelint: Disable custom-property-empty-line-before 2022-05-22 19:58:14 -07:00
Ryan Berliner
27261bd495 add back focus box shadow on btn link 2022-05-20 11:19:17 -07:00
louismaxime.piton
00d028e646 Adding @include everytime it's not the case 2022-03-31 14:41:02 -07:00
Mark Otto
acf6ea74a7
Add additional root variables, rename $variable-prefix to $prefix (#35981)
* Add additional root variables, rename $variable-prefix to $prefix

- Adds new root CSS variables for border-radius, border-width, border-color, and border-style
- Adds new root CSS variables for heading-color, link-colors, code color, and highlight color
- Replaces most instances of Sass variables (for border-radius, border-color, border-style, and border-width) for CSS variables inside _variables.scss
- Updates $mark-padding to be an even pixel number
- Renames $variable-prefix to $prefix throughout

* Bundlewatch
2022-03-13 10:13:09 -07:00
Eugene Kopyov
2a09f10676 Fixed border radius var name and .show target 2022-02-16 08:48:54 -08:00
Mark Otto
ef9d8538a0 Convert .btn and mixins to use CSS variables 2022-02-14 19:00:59 -08:00
Mark Otto
09f73a6a12 Revert "Add align-self: center to buttons for improved rendering in flex containers" (#35143)
This reverts commit 94c80ff613.
2021-10-09 09:41:51 +03:00
Zaid Jawed
94c80ff613
Add align-self: center to buttons for improved rendering in flex containers
Fixes #34834
2021-09-07 13:21:57 -07:00
Mark Otto
4c7a3e8adf
Add Sass docs (variables, mixins, and loops) to most pages (#32747)
* WIP: Mention variables, mixins, and loops in docs

* Add Sass sections to component pages

* add sass docs for forms and content

* Update buttons.md

* Remove empty mixins sections

* Massive update to utilities and some consistency changes

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-10 19:29:59 -08:00
Mark Otto
fb3a57b7ba
Drop .btn-block classes, replace with utilities (#31995)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-09 11:27:20 +02:00
Martijn Cuppens
8b7b234fd1 Switch to btn-check 2020-06-15 19:04:19 -07:00
Martijn Cuppens
1a0a0858ef Remove checkbox/radio toggle from button plugin in favor of a CSS only solution 2020-06-15 19:04:19 -07:00
XhmikosR
3d8d0012c8
Stylelint: remove redundant disables (#31006) 2020-06-12 11:11:36 +03:00
Mark Otto
0408799ae5 Rename variables for brevity
- Rename `$enable-prefers-reduced-motion-media-query` to `$enable-reduced-motion`
- Rename `$enable-pointer-cursor-for-buttons` to `$enable-button-pointers`
2020-04-26 17:26:04 -07:00
Tim Dujardin
3e5bc4c56d
Added focus state to .btn-link (#30036) 2020-03-23 18:08:17 +01:00
Martijn Cuppens
7fc4037a02 Remove redundant text decoration from hover states 2020-03-20 09:35:55 +01:00
Martijn Cuppens
d9215ebd5a
$link-decoration: underline affects some components (#30262)
Co-authored-by: Shohei Yoshida <fellows3@gmail.com>
Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
2020-03-05 15:22:52 +01:00
Martijn Cuppens
4387038421 Simplify disabled styles (#29296)
* Simplify disabled styles

* Mention pointer-events usage
2019-12-27 18:40:06 +02:00
Martijn Cuppens
9ee9b8a1e8 Add configurable button text wrapping (#29554) 2019-10-25 12:37:52 +03:00
Martijn Cuppens
007ea0d8d0 Clean up line heights & add line height utilities (#29271) 2019-08-30 10:42:41 +03:00
Martijn Cuppens
ceddca71a2 Restore cursor: pointer for checkbox/radio buttons (#29239) 2019-08-16 11:36:13 +03:00
Martijn Cuppens
d479fd89d0 Remove attribute selectors (#28988) 2019-07-12 13:15:50 +03:00
Mark Otto
1d4d9f8d89 Drop all hover mixins
Previously deprecated in v4.x, this clears out the now unused Sass option and removes some unused mixins. Arguably we could remove more, but I like the hover-focus mixin and we make extensive use of it across the project.
2019-05-08 20:58:07 +03:00
GeoSot
275cd7f91e Separate $btn-link colors from $link-color (#28681) 2019-04-23 16:12:51 +03:00
Martijn Cuppens
8b41cb1368 Optional btn & input font sizes (#28068) 2019-02-07 19:47:24 +02:00
Bardi Harborow
b5fb4f7d6b Add text-decoration to .btn-link. (#28169) 2019-02-06 22:33:03 +01:00
Martijn Cuppens
e1b990fb90 Move hand cursor for buttons to reboot 2019-01-04 11:53:32 +02:00
Martijn Cuppens
a6669b478b Fix btn focus color (#27178) 2018-10-17 23:21:33 +03:00
Martijn Cuppens
e604958641 Variable .btn and .form-control font sizes (#26908) 2018-09-18 15:35:25 +03:00
Martijn Cuppens
bf4dab72df #27220: cleanup .btn-link hover/focus properties (#27250) 2018-09-17 09:34:34 -03:00
Martijn Cuppens
97eea3b2bf Set .btn base color 2018-09-02 16:28:42 -07:00
Martijn Cuppens
3ef2db1e85 Move transparent background to .btn and remove background-image 2018-09-02 16:28:42 -07:00
Rowan-James Tran
24bdadf9d3 Remove nowrap from .btn 2018-08-19 11:17:10 -07:00
Martijn Cuppens
c74a32703a Allow background images for active buttons 2018-07-20 19:25:01 -05:00
Peter Etelej
fb15575ec5 Disable link functionality on disabled btn-link (#25645)
Future-proof disabling of clicks on disabled `btn-link`. Fixes #25639
ensuring consistency between `btn-link` `<button>`s and `<a>`s when disabled.
2018-03-12 19:36:25 +02:00
Mark Otto
a0936c326f Outline button hover color (#25339) 2018-01-18 01:45:25 +02:00
Patrick H. Lauke
1f490ec165
Consistently use :disabled rather than [disabled] selector (#25317)
Closes https://github.com/twbs/bootstrap/issues/25316
2018-01-15 20:51:01 +00:00
Mark Otto
afc984dca7 line break 2017-12-27 17:56:28 -08:00