From 4b00aa6c4ec9281ad27659babb0e208ab6cdeafa Mon Sep 17 00:00:00 2001 From: "Patrick H. Lauke" Date: Tue, 19 Feb 2019 09:25:37 +0000 Subject: [PATCH] Remove incorrect aria-haspopup from dropdown toggles (#28299) `aria-haspopup` use requires the use of an ARIA `menu`, `listbox`, `tree`, `grid` or `dialog` (see https://www.w3.org/TR/wai-aria-1.1/#aria-haspopup) in our use (as generic disclosure widgets), it's incorrect and sets up the wrong assumption/behavior from assistive technologies. in future, we likely want to change our dropdowns to essentially be like a `dialog` - move focus to it when opened, possibly make it modal so focus is maintained inside it and the rest of the page is hidden/inert. but for now, removing the incorrect attribute is probably the quickest, most immediate fix. --- js/tests/unit/dropdown.js | 2 +- js/tests/visual/dropdown.html | 26 +++--- js/tests/visual/scrollspy.html | 2 +- js/tests/visual/tab.html | 10 +-- site/_includes/docs-navbar.html | 2 +- site/docs/4.3/components/button-group.md | 10 +-- site/docs/4.3/components/dropdowns.md | 86 +++++++++---------- site/docs/4.3/components/input-group.md | 8 +- site/docs/4.3/components/navbar.md | 4 +- site/docs/4.3/components/navs.md | 4 +- site/docs/4.3/components/scrollspy.md | 4 +- site/docs/4.3/examples/jumbotron/index.html | 2 +- .../4.3/examples/navbar-bottom/index.html | 2 +- site/docs/4.3/examples/navbars/index.html | 18 ++-- site/docs/4.3/examples/offcanvas/index.html | 2 +- .../4.3/examples/starter-template/index.html | 2 +- 16 files changed, 92 insertions(+), 92 deletions(-) diff --git a/js/tests/unit/dropdown.js b/js/tests/unit/dropdown.js index 1ecfd1f8bf..a94595ad20 100644 --- a/js/tests/unit/dropdown.js +++ b/js/tests/unit/dropdown.js @@ -727,7 +727,7 @@ $(function () { var done = assert.async() var html = '